Repository navigation
Conversation
Cargo Vet Audit Passed
|
Configure an explicit AC or DC source before starting the timer runner and drive its latched wake level on GPIO1. Disable initial fixture alarms to keep startup idle-low and leave ordinary initialization unchanged. Preserve upstream's shared HID TimeAlarm and MCTP services and the one-argument initializer. Pin the rebased library wake changes and retain the HAL's zero-gap I2C transaction-boundary fix. Assisted-by: GitHub Copilot:gpt-6-astra Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require an initialized input before starting the runner and track source changes with GPIO level interrupts. Preserve default builds and the construction-time wake fixtures. Assisted-by: GitHub Copilot:gpt-6-astra Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dymk
force-pushed
the
dymk/time-alarm-power-input
branch
from
October 16, 2026 22:32
f12cf11 to
f27725d
Compare
dymk
marked this pull request as ready for review
October 19, 2026 20:00
dymk
requested review from
kat-perez,
maxperga-msft,
rogurr and
williampMSFT
and
a balanced review from Copilot
October 19, 2026 20:00
There was a problem hiding this comment.
🔵 Needs a closer look
Coordinated HAL, QEMU, and service dependencies require final human integration review of interrupt and wake behavior.
No open issues 🎉
What changed in this PR
Adds opt-in GPIO2-based AC/DC selection to QEMU’s shared TimeAlarm service, preserving default initialization and explicit wake fixtures.
Changes:
- Validates and selects the initial power source before TimeAlarm starts, then tracks GPIO2 changes.
- Keeps GPIO1 as the wake output and GPIO0 as the HID interrupt.
- Adds feature flags, dependency updates, and fixture documentation.
| File | Description |
|---|---|
| platform/platform-common/src/mock/time_alarm.rs | Adds configuration before the service runner starts. |
| platform/platform-common/src/mock/mod.rs | Exposes configurable TimeAlarm initialization. |
| platform/dev-qemu/src/main.rs | Implements source selection, monitoring, and wake output. |
| platform/dev-qemu/src/board.rs | Configures GPIO1 output and asynchronous GPIO2 input. |
| platform/dev-qemu/README.md | Documents wake fixtures and emulated power input. |
| platform/dev-qemu/Cargo.toml | Adds opt-in features and pins the temporary HAL fork. |
| platform/dev-qemu/Cargo.lock | Updates HAL and service dependency revisions. |
Review effort: Balanced
RobertZ2011
approved these changes
Oct 19, 2026
dymk
enabled auto-merge (squash)
October 19, 2026 23:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in time-alarm-power-input mode. It checks GPIO2 initialization before starting TimeAlarm, selects AC for high and DC for low, and updates the service when the input changes. GPIO1 remains the wake output; GPIO0 remains HID. Default builds and explicit construction-time AC/DC fixtures remain unchanged.
This is QEMU-emulated external power, not physical hardware detection or Windows power-policy notification. Uninitialized input fails startup rather than silently selecting DC.
Depends on #50 and OpenDevicePartnership/odp-qemu-builder#12. This is the single commit after #50, now on upstream's HID TimeAlarm (#53) and using #50's
init_with_time_alarm_configure. The temporary HAL fork pin keeps the I2C transaction-boundary fix and adds the generated input-validity register and typed accessor.Default, wake-fixture, and power-input release builds, strict Clippy, fmt, and
cargo vetpass. Real FF-A/SP/EC source-switch qualification passes for both cold AC and DC starts in OpenDevicePartnership/odp-platform-qemu-arm-virt#183, including INSTANTLY versus NEVER after acknowledged source changes; the four retention wake cases also pass with this EC.Part of OpenDevicePartnership/embedded-services#689. Windows-managed S4 work is separate.