Repository navigation
Conversation
| `cargo make -p release build-no-alloc` | ||
| """ | ||
| clear = true | ||
| script_runner = "@duckscript" |
There was a problem hiding this comment.
Does this need to also run on aarch64-pc-windows-msvc? Or, for consistency, could it have a conditional script like build-x64?
There was a problem hiding this comment.
That is what I started, to only run on x64 because only supv uses that. But I thought it might be useful for aarch64 as well. I can scope it down to x64 if that is more desirable.
There was a problem hiding this comment.
It is fine either way. If it stays, maybe address the inconsistency with the other tasks by saying those are skipped because it is unexpected to cross-compile for X64 targets from AARCH64, whereas this is a correctness check independent of architectures.
There was a problem hiding this comment.
I went back check the current status once again and think it makes better sense to keep it to x64 for now. We can expand it to aarch64 when it is needed.
This is now moved under cargo make check-no-alloc-x64.
4 participants
This change adds a build task that allows the build for crates that do not pull in
alloc.For crates that would like to opt-in for this build, one should set the following and trigger build with
cargo make build-no-alloc: