Repository navigation
Restore saved LED controls when reopening device details - #327
Merged
TobiasRoeddiger merged 2 commits intoOct 5, 2026
Merged
TobiasRoeddiger merged 2 commits into
TobiasRoeddiger merged 2 commits into
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit ec4ccb5): https://open-earable-web--pr327-codex-restore-led-co-w0eq59bo.web.app (expires Mon, 02 Nov 2026 02:17:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
Contributor
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/37264280699 |
TobiasRoeddiger
marked this pull request as ready for review
October 5, 2026 04:36
TobiasRoeddiger
merged commit Oct 5, 2026
980dfba
into
automation/bump-version-1.5.4-36858743484
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device details resets the LED switches when reopened, even though the earphone retains the setting. Read back the saved mode and color on firmware 2.3.0, keep the color picker usable for a black override, and retain confirmed state after failed writes. Older firmware keeps its existing controls without unsupported reads.
Uses OpenEarable/open_earable_flutter#157. All 125 focused app tests pass and analysis is clean. On the real Pixel app, both 2.3.0 earphones retained disabled state and RGB208,20,20 after leaving and reopening; original settings restored. Both official2.2.9 ears retained working write-only controls. The integrated app with the Posture/logging fixes passes127 tests and Android build. Physical LED appearance was not inspected.