Skip to content

Improve spatial fields and bbox #276 - #321

Open
Ludee wants to merge 3 commits into
developfrom
feature-276-bbox-null
Open

Ludee wants to merge 3 commits into
developfrom
feature-276-bbox-null

Conversation

@Ludee

@Ludee Ludee commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary of the discussion

Describe the findings of the discussion in the issue or meeting.

Type of change (CHANGELOG.md)

Changed

  • Update spatial context keys (#321)

Workflow checklist

Automation

Closes #276

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee self-assigned this Sep 25, 2026
@Ludee
Ludee requested a review from Cpprentice September 25, 2026 09:48
@Ludee

Ludee commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

This is ready for review.

@Cpprentice Cpprentice left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context update of spatial is weird as it seems to reintroduce the older version from before issue 318.

The other comment is just a small improvement.

"dc": "http://purl.org/dc/elements/1.1/",
"dcat": "https://www.w3.org/ns/dcat#",
"dct": "https://purl.org/dc/terms/",
"EPSG": "http://www.opengis.net/def/crs/EPSG/0/",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see any use of EPSG in the context.json for now so I am not sure if it is needed.

I guess this was intended to be able to resolve the values in the crs field that is pattern constraint to an "EPSG:" prefix now.

But for that I believe it is mandatory to set "@type": "@id" instead of a string in line 299.

"@id": "sc:Grant",
"@type": "xsd:string"
},
"spatial": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I added a @nest for the spatial object in my context overhaul which would likely not cause a blank node with all that stuff inside but assign that directly to the parent object.
Also there was no nested @context before.

It seems to me that this just includes the old entries that have been in the context before. Please check and make sure we get a proper update in the end.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bounding box should allow "null" types as value

2 participants