Repository navigation
Conversation
|
This is ready for review. |
Cpprentice
left a comment
There was a problem hiding this comment.
The context update of spatial is weird as it seems to reintroduce the older version from before issue 318.
The other comment is just a small improvement.
| "dc": "http://purl.org/dc/elements/1.1/", | ||
| "dcat": "https://www.w3.org/ns/dcat#", | ||
| "dct": "https://purl.org/dc/terms/", | ||
| "EPSG": "http://www.opengis.net/def/crs/EPSG/0/", |
There was a problem hiding this comment.
I did not see any use of EPSG in the context.json for now so I am not sure if it is needed.
I guess this was intended to be able to resolve the values in the crs field that is pattern constraint to an "EPSG:" prefix now.
But for that I believe it is mandatory to set "@type": "@id" instead of a string in line 299.
| "@id": "sc:Grant", | ||
| "@type": "xsd:string" | ||
| }, | ||
| "spatial": { |
There was a problem hiding this comment.
I think I added a @nest for the spatial object in my context overhaul which would likely not cause a blank node with all that stuff inside but assign that directly to the parent object.
Also there was no nested @context before.
It seems to me that this just includes the old entries that have been in the context before. Please check and make sure we get a proper update in the end.
Summary of the discussion
Describe the findings of the discussion in the issue or meeting.
Type of change (CHANGELOG.md)
Changed
Workflow checklist
Automation
Closes #276
PR-Assignee
Reviewer