Skip to content

Feature 320 atid - #322

Open
Ludee wants to merge 8 commits into
developfrom
feature-320-atid
Open

Ludee wants to merge 8 commits into
developfrom
feature-320-atid

Conversation

@Ludee

@Ludee Ludee commented Sep 25, 2026

Copy link
Copy Markdown
Member

Summary of the discussion

Update the @id fields to simple "id".
The databus @id is unchanged.

Type of change (CHANGELOG.md)

Changed

Workflow checklist

Automation

Closes #320

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee self-assigned this Sep 25, 2026
@Ludee
Ludee requested a review from Cpprentice September 25, 2026 11:52

@Cpprentice Cpprentice left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments that might need changes to the context.json file.

Also I think we have to clarify the difference between path and id on top level.

@@ -17,7 +17,7 @@
"readOnly": true
},
"@id": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also modify this id field?

"format": "uri",
"readOnly": true
},
"path": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This compares to the previous @id field in the sense that it is meant for the OEP table while the other relates to the databus?

How would this be filled for datasets that are neither on the databus nor the OEP?

"format": "uri",
"readOnly": true
},
"path": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to modify the context.json as well if we add the new path property here.

Path currently has several definitions depending on the nested context:

# review context (alias)
"path": "@id"      # this means whatever contains the path keyword gets the value as its iri


# global context (property declaration)
"path": {        # in comparison to the above comment, this defines a property whose value becomes an iri
      "@id": "dcat:accessURL",
      "@type": "@id"
    }


# resource context
"path": {
          "@id": "dct:identifier",
          "@type": "xsd:string"
}

# context of sources, sourceLicenses, and resourceLicenses
"path": {
          "@id": "dcat:accessURL",
          "@type": "xsd:anyURI"
        }

If we have at least one @id alias in the top level the entire metadata descriptor would get an IRI otherwise it is a blank node. Both are fine we should just properly think about how we handle both

"id" and "path" in that regard. I am not 100% sure what happens if we identify one of them as alias for @id and the value is not filled.

"title": "Dataset Extent Name"
},
"@id": {
"id": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context.json currently only has this definition for "id" (it is in the global scope):

 "id": {
      "@id": "dct:identifier",
      "@type": "xsd:anyURI"
    }

I assume we rather need to alias it now:

"id": "@id"

Also I did not found any occurrence of a mere "id" field (without the @) in the previous schema.json so maybe the above can simply be replaced without further issues.

@Cpprentice

Cpprentice commented Oct 6, 2026 •

Copy link
Copy Markdown

I will have a look into the occurrences of path and id to see if we need more detailled disambiguation.
Updates will be pushed onto the branch for this pull request directly.

We want to use dcat:landingPage whenever possible for a path.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "@id" fields cause problems, rename to "id"

2 participants