Repository navigation
Conversation
Correct credential visibility, roles, MFA, console.log setting and zero-persistence wording against Lightning, and replace 404 links. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Rewrite security.md around the six implementation phases from the approved deck, with risks, practices, OpenFn settings and phase-gate checks for each. Correct misleading claims about credentials, zero persistence and data residency, console.log settings, the audit trail, and MFA. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Reworks the implementation security guidance around the six phases in the approved deck, and corrects the confusing or misleading claims from the first version of this PR.
Fixes https://github.com/OpenFn/ofg-services-internal/issues/131, https://github.com/OpenFn/ofg-services-internal/issues/138
Details
Facts were checked against
OpenFn/lightning@3b9f4a2andOpenFn/kit@5b42eff.get-started/security.md: rewritten by phaseget-started/security-compliance.mdpolicies/users.ex), but an Editor's job code receives the values at runtime. Removed "purged when deleted", which I couldn't verify.hooks.ex:limit_mfa).build-for-developers/security-for-devs.mdstate.json. It now points to credentials, and to a credential map kept out of the repository for the CLI (the CLI doesn't gitignore it).none(run_with_options.ex), and adaptor and runtime logs still show. Merged the two duplicate bullets.Related pages
build/workflows.md: Editors can change the log setting (edit_workflowis an editor action), not only owners and admins.manage-projects/io-data-storage.md: replaced the "data sovereignty" claim with what zero persistence does, including that retries stop working and channel payloads aren't stored.get-started/implementation-checklist.md: links to the phase-based security page.yarn generate-adaptors && yarn buildpasses for all locales, and these pages add no new broken-anchor warnings.Left for later
/translaterun in a separate PR.OpenFn/kit, the CLI could gitignore or warn about credential files.cli-sync.mdmentions--credential-map, but the CLI option is--credentials(options.ts:285).security-compliance.md(H1, em dashes) and the bold-label bullets insecurity-for-devs.md, left to keep this PR focused.Questions
healthdataprinciples.organdgicsandbox.orgtime out from scripts and need a check in a browser.digitalprinciples.orgreturns 403 to scripts.AI Usage
You can read more details in our
Responsible AI Policy
🤖 Generated with Claude Code