Skip to content

Bump decimal and cowlib, ignore the Cloak advisories in hex.audit - #5246

Merged
stuartc merged 2 commits into
mainfrom
stuart/hex-audit-advisories
Oct 14, 2026
Merged

stuartc merged 2 commits into
mainfrom
stuart/hex-audit-advisories

Conversation

@stuartc

@stuartc stuartc commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Description

mix hex.audit started failing CI on branches off main because of new advisories against cloak, cloak_ecto and decimal. Where a fix exists we take it, and where it doesn't we ignore the advisory after checking it can't reach us.

Validation steps

  1. mix deps.get && mix hex.audit exits 0 and lists the three ignored advisories.
  2. grep -rnE "AES\.CTR|PBKDF2" lib config finds nothing.

Additional notes for the reviewer

  1. If anyone later adds a CTR cipher or a PBKDF2 field, these ignores will hide a real problem. The comment in mix.exs says so next to each one.

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

decimal 3.2.0 fixes CVE-2026-97853 and cowlib 2.21.0 fixes CVE-2026-43969,
so that ignore goes. Neither Cloak advisory has a patched release, and
neither reaches us: our only cipher is AES.GCM and we define no PBKDF2
fields.
@github-project-automation github-project-automation Bot moved this to New Issues in Core Oct 14, 2026
@github-actions

Copy link
Copy Markdown

Verified: Lightning uses only Cloak.Ciphers.AES.GCM (lib/lightning/vault.ex:14) and no PBKDF2 fields anywhere in lib/ or config/, so the two added Cloak CVE ignores match the code. The diff is strictly mix.exs and mix.lock.

Security Review ✅

  • S0 (project scoping): N/A, PR only touches mix.exs and mix.lock — no queries, controllers, or LiveView events changed.
  • S1 (authorization): N/A, no new web-layer actions or policy modules.
  • S2 (audit trail): N/A, no writes to config resources; only dependency version bumps and hex_audit advisory list edits, which the ignores' rationale (lib/lightning/vault.ex:14, no PBKDF2 usage) actually matches.

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.4%. Comparing base (bc28b49) to head (9afebef).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5246   +/-   ##
=====================================
  Coverage   91.4%   91.4%           
=====================================
  Files        465     465           
  Lines      23416   23416           
=====================================
+ Hits       21404   21410    +6     
+ Misses      2012    2006    -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stuartc
stuartc merged commit aac8674 into main Oct 14, 2026
8 checks passed
@stuartc
stuartc deleted the stuart/hex-audit-advisories branch October 14, 2026 10:33
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant