Repository navigation
Bump decimal and cowlib, ignore the Cloak advisories in hex.audit - #5246
Merged
Merged
Conversation
decimal 3.2.0 fixes CVE-2026-97853 and cowlib 2.21.0 fixes CVE-2026-43969, so that ignore goes. Neither Cloak advisory has a patched release, and neither reaches us: our only cipher is AES.GCM and we define no PBKDF2 fields.
|
Verified: Lightning uses only Security Review ✅
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5246 +/- ##
=====================================
Coverage 91.4% 91.4%
=====================================
Files 465 465
Lines 23416 23416
=====================================
+ Hits 21404 21410 +6
+ Misses 2012 2006 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mix hex.auditstarted failing CI on branches off main because of new advisories against cloak, cloak_ecto and decimal. Where a fix exists we take it, and where it doesn't we ignore the advisory after checking it can't reach us.Decimal.round/3memory blow-up with a hugeplaces). We don't callDecimal.roundourselves, but the bump is free.Lightning.Vaultonly usesCloak.Ciphers.AES.GCM, which authenticates its ciphertext. No fixed release exists; upstream issue CVE-2026-95105: AES.CTR cipher is unauthenticated (deprecate it in favour of AES.GCM?) danielberkompas/cloak#132.Cloak.Ecto.PBKDF2ignores:iterations) is ignored. We define no PBKDF2 fields, onlyCloak.Ecto.BinaryandCloak.Ecto.Map. No fixed release exists; upstream issue CVE-2026-94206: PBKDF2 type passes :size as the iteration count danielberkompas/cloak_ecto#66.Validation steps
mix deps.get && mix hex.auditexits 0 and lists the three ignored advisories.grep -rnE "AES\.CTR|PBKDF2" lib configfinds nothing.Additional notes for the reviewer
mix.exssays so next to each one.AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)