Skip to content

Add behaviour annotations for views, flows and shared components - #5251

Closed
brandonjackson wants to merge 14 commits into
mainfrom
claude/update-lightning-annotations-5uzaq5
Closed

brandonjackson wants to merge 14 commits into
mainfrom
claude/update-lightning-annotations-5uzaq5

Conversation

@brandonjackson

Copy link
Copy Markdown
Contributor

Description

This PR adds the annotations/ directory: behaviour annotations for Lightning's UI, brought over from claude/tender-mendel-0pejfc (batches 1 to 5).

  • annotations/TEMPLATE.md and annotations/INVENTORY.md
  • annotations/views/: 25 view annotations (project settings tabs, history, run page, channels, sandboxes, workflow editor canvas, inspectors, IDE, manual run, and more)
  • annotations/flows/: 34 consolidated flow annotations
  • annotations/shared/: 17 shared annotations

Docs only. No application code changes.

Validation steps

  1. Confirm every changed file is under annotations/.

Additional notes for the reviewer

  1. Markdown only, so there's no runtime impact.

AI Usage

  • I have used Claude Code
  • I have used another model
  • I have not used AI

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

https://claude.ai/code/session_01DPKLRy44TRJ73zQQz6oeDi


Generated by Claude Code

claude added 14 commits October 14, 2026 18:12
Phase 1 of cataloguing Lightning for the rebuild: annotations/ folder,
the v2 template, an inventory of 49 views, and the shared annotations for
the project scope gate, usage limits banner and credential index component.

Claude-Session: https://claude.ai/code/session_01RqxAu9NCNvyAQN7vAKhfQy
… ids

Adds annotations for workflows-index, history-work-orders,
project-settings-setup, project-settings-collaborators and
credentials-index, with lead resolutions of their proposed flows and
shared annotations, and updates the inventory.

Claude-Session: https://claude.ai/code/session_01RqxAu9NCNvyAQN7vAKhfQy
Adds credentials, webhook security, security, GitHub sync and data
storage tab annotations, wires them to consolidated ids, and adds the
credentials tab as an entry to the three credential flows.

Claude-Session: https://claude.ai/code/session_01RqxAu9NCNvyAQN7vAKhfQy
…anual run

Also repairs INVENTORY.md: restores four main-table rows removed by
earlier cleanup and moves pending rows that had landed in the main table.

Claude-Session: https://claude.ai/code/session_01RqxAu9NCNvyAQN7vAKhfQy
Seven of eight files from the batch 5 consolidation run; the run was
still going at commit time, so some may be updated again.

Claude-Session: https://claude.ai/code/session_01RqxAu9NCNvyAQN7vAKhfQy
@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — PR adds only Markdown annotation files under annotations/; no queries or web-layer entrypoints changed.
  • S1 (authorization): N/A — no controllers, LiveViews, channels, or policy modules modified; nothing under test/lightning/policies/ touched.
  • S2 (audit trail): N/A — no Repo.insert/update/delete or Ecto.Multi changes; no config-resource writes added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants