Skip to content

Make oieserver compatible with apple bash - #199

Merged
tonygermano merged 1 commit into
OpenIntegrationEngine:mainfrom
mgaffigan:bugfix/oieserver-macos
Nov 6, 2025
Merged

tonygermano merged 1 commit into
OpenIntegrationEngine:mainfrom
mgaffigan:bugfix/oieserver-macos

Conversation

@mgaffigan

Copy link
Copy Markdown
Contributor

Closes #198

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@mgaffigan
mgaffigan force-pushed the bugfix/oieserver-macos branch from 6101954 to c50858b Compare November 1, 2025 22:40
@kpalang
kpalang requested review from a team, jonbartels, kayyagari, ssrowe and tonygermano and removed request for a team November 3, 2025 08:05
@kpalang

kpalang commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

For future reference, the approach used before this PR works starting with Bash 4.2, but MacOS ships with Bash 3.2.

@jonbartels jonbartels left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shebang for bash specifically #!/usr/bin/env bash

So this is bash only and doesn't need to be comapatible with zsh the default shell in MacOS.

LGTM

@tonygermano
tonygermano merged commit c50858b into OpenIntegrationEngine:main Nov 6, 2025
2 checks passed
jcdlbs added a commit to SagaHealthcareIT/open-integration-engine that referenced this pull request Oct 29, 2026
…ved files

The four test files added with the ICSMA-26-253-01 fixes and Migrate4_6_0
carried the Mirth Corporation header although Mirth wrote none of them.
DatabaseConnectorServletTest, XsltStepTest and XMLBatchAdaptorTest derive
from benjodo's BridgeLink pull requests (OpenIntegrationEngine#200, OpenIntegrationEngine#198, OpenIntegrationEngine#199; BridgeLink is
MPL 2.0, so copyright stays with the contributor) and were substantially
reworked here; DriverInfoSelectLimitTest and Migrate4_6_0 are Saga-authored.
All five now carry SPDX MPL-2.0 headers naming the actual authors, matching
the fork's convention for new files. Modified Mirth files keep their
original notices as MPL requires.

[4.7.0 port] Only the Migrate4_6_0 hunk is kept. The four test files it
also re-headered came with fork-only ICSMA-26-253-01 fixes that upstream
4.7.0 supersedes, so those fixes and their tests are not carried.

(cherry picked from commit 9c5888f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] oieserver.sh fails on OS X

4 participants