Repository navigation
Fix authenticated sqli - #524
Merged
Merged
Conversation
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
October 28, 2026 01:08
NicoPiel
approved these changes
Oct 28, 2026
tonygermano
approved these changes
Oct 28, 2026
tonygermano
left a comment
tonygermano
left a comment
Member
There was a problem hiding this comment.
suggestion (non-blocking): Gemini said you can do this in a database-agnostic way where the concatenation occurs before it hits the database engine.
<if test='name != null'>
<bind name="namePattern" value="'%' + name + '%'" />
AND LOWER(NAME) LIKE LOWER(#{namePattern})
</if>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derby and MySQL allow EOP via SQLi at
GET /events?name=<payload>. Authentication is still required, so this vulnerability specifically affects MySQL or Derby users that are using RBAC.