Repository navigation
Conversation
MirthWebServer never closed the downloaded file's stream on success, so each download leaked a file handle. Also close the Statement in DefaultDatabaseTaskController.executeUpdate, and close the socket, connection or file when setup fails after creation in SocketUtil, DisabledConnectionPool and UnzipEngine. The extension manager and PDF viewer now use try-with-resources. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
kpalang,
mgaffigan,
pacmano1 and
ssrowe
October 28, 2026 13:25
mgaffigan
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MirthWebServer never closed the downloaded file's stream on success, so each download leaked a file handle. Also close the Statement in DefaultDatabaseTaskController.executeUpdate, and close the socket, connection or file when setup fails after creation in SocketUtil, DisabledConnectionPool and UnzipEngine. The extension manager and PDF viewer now use try-with-resources.