Skip to content

refactor(drivers)!: remove false capabilities and share OpenList protocol - #3133

Open
nostalume wants to merge 4 commits into
OpenListTeam:mainfrom
nostalume:refactor/domain6-capability-family
Open

nostalume wants to merge 4 commits into
OpenListTeam:mainfrom
nostalume:refactor/domain6-capability-family

Conversation

@nostalume

@nostalume nostalume commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary / 摘要

Remove 41 optional Driver methods in 16 packages whose only result was errs.NotImplement; operation-level absence now represents these unsupported capabilities directly. Consolidate duplicated AList V3 and OpenList request/login, object, link, mutation, upload, and archive mechanisms in one family-local implementation while retaining both concrete products, their Addition schemas, and their role/refresh/overwrite dialects. Add behavior tests for absent-capability errors, shared listing/link behavior, and dialect-specific requests.

The candidate changes 28 files: production +724/-1279 (net -555 lines), tests +264/-27 (net +237), overall net -318. No config or storage migration is required. Source compatibility: exported concrete methods that only returned NotImplement are removed. External Go code calling those methods directly must adapt; repository callers use capability interfaces. The AList V3 and OpenList product/package paths and persisted Addition fields remain.

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。
  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。
  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR: none known.

Related Issues / 关联 Issue

Relates to #3098 only as a cross-domain architecture anchor; #3098 itself remains scoped to transfer resource lifetime. The reviewer-facing PR sequence distinguishes this independent Driver candidate from #3131 and #3132. It is not stacked on either PR and has no overlapping changed files. The explicit Driver catalog is a later, separately reviewed boundary.

Testing / 测试

  • Windows Go 1.27.1: go test -count=1 ./drivers/alist_v3 ./drivers/openlist ./drivers/internal/openlist ./internal/op — pass.

  • Windows: go test -run '^$' -vet=off ./drivers/..., go vet ./drivers/alist_v3 ./drivers/openlist ./drivers/internal/openlist ./internal/op, and go build ./... — pass. All Driver packages compile.

  • WSL Tumbleweed Go 1.27.1: go test -race -count=1 ./drivers/alist_v3 ./internal/op — pass.

  • git diff --check, committed Go blob gofmt check, and connectivity fsck — pass.

  • Windows go test ./... — fails in dynamic-format vet and environment-sensitive tests also seen on the unchanged main@54ae9d74 baseline (including OneDrive sharelink, multipart, internal/net, aria2/rpc, MCP). A preceding run also had a timing-sensitive pkg/task failure; do not claim the full suite green.

  • No manual provider/end-to-end test is claimed.

  • go test ./...

  • Manual test / 手动测试:

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING。
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmt、go fmt 或 prettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

nostalume and others added 3 commits September 24, 2026 21:03
- Remove unconditional unsupported mutation and archive-decompress methods from 16 drivers.

- Let operation dispatch represent unavailable capabilities through interface absence without adding a compatibility layer.

Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
- Share the AList V3 and OpenList protocol mechanism while retaining product shells and dialects.

- Replace duplicated implementation with focused family behavior and dialect tests.

Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
- Check operation-level NotImplement behavior for unavailable copy and archive capabilities.

- Exercise shared AList/OpenList link forwarding and cache-key context through both product shells.

Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant