Don't export OpenLoco / OpenGraphics objects with scenario or save files - #4033
Open
shusaura85 wants to merge 5 commits into
Open
shusaura85 wants to merge 5 commits into
shusaura85 wants to merge 5 commits into
Conversation
Mirror isCustom() and isVanilla() functions. Returns true is source game is openLoco
Move it under isVanilla() function to keep order with SourceGame options
Check if the object's source is openLoco and skips it if it is.
Since we now have a function for checking if an object is OpenLoco source.
LeeSpork
approved these changes
Sep 20, 2026
AaronVanGeffen
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds isOpenLoco() function to Object.h mirroring isCustom() and isVanilla functions and expanded the check when exporting plug-in objects to also check isOpenLoco() before saving objects.
Also updates Object Selection window replacing the raw comparison with the new function for the object source filtering options.
Rationale behind changes
This affects what objects are saved in scenario or save files. Objects marked as OpenLoco (such as OpenGraphics objects) should not be included in saved scenarios or save games (when "export plug-in objects with save games" is enabled).
OpenGraphics are part of every OpenLoco install so there's no point in including them with each save increasing the file size (using "North America Expanded" region included in v26.09 (with no other changes to other scenario creation options) would create a scenario file of around 15MB compared to around 0.8MB if OG objects not included)
Suggested testing steps
Did you use AI to help find, test, or implement this issue or feature?
No AI was used for these changes.