Repository navigation
Fix npm/Meteor security advisories in app and ingest - #215
Merged
Merged
Conversation
ingest (15 advisories -> 0): - Replace abandoned expr-eval (critical RCE, prototype pollution, no upstream fix) with the drop-in expr-eval-fork. - jimp 0.22 -> 1.6: migrate the costmap handler to the promise API and add a round-trip test for it. - mocha 11 -> 12: replace the unmaintained mocha-prepare hook with mocha's built-in mochaGlobalSetup fixture. app (44 advisories -> 9): - npm audit fix for all non-breaking advisories (handlebars, protobufjs, websocket-driver, plotly, lodash, js-yaml, ...). - Meteor packages: collection2 4.2.2, meteortesting:mocha 3.4.0, aldeed:simple-schema 2.0.0. Remove the unused, deprecated http package. - rest_api: use the WHATWG URL API instead of url.parse(). Left as-is (need major migrations): react-router 6 -> 8, and the dev-only @rspack/cli 2.x chain (requires @meteorjs/rspack 3, still beta). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
✅ Deploy Preview for ornate-croquembouche-cc5482 canceled.
|
mocha-junit-reporter 2.2.1 (latest) is incompatible with mocha 12
("Class constructor Base cannot be invoked without 'new'"). Mocha's
bundled xunit reporter emits a single <testsuite> root, which
dorny/test-reporter's java-junit parser accepts.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expr-eval(critical RCE / prototype pollution, no upstream fix) with the drop-inexpr-eval-fork;jimp0.22 → 1.6 with the costmap handler migrated to the promise API plus a new round-trip test;mocha11 → 12, replacing the unmaintainedmocha-preparewith mocha's built-inmochaGlobalSetupfixture.npm audit fixfor every non-breaking advisory (handlebars, protobufjs, websocket-driver, plotly, lodash, js-yaml, ...); Meteor packagesaldeed:collection24.2.2,meteortesting:mocha3.4.0,aldeed:simple-schema2.0.0; removed the unused, deprecatedhttppackage;rest_api.jsnow uses the WHATWGURLAPI instead ofurl.parse().Deliberately not done (need major migrations)
react-router6 → 8 (two moderate advisories).@rspack/cli2.x: the remaining 7 app advisories, all via dev-onlywebpack-dev-server, which Meteor's rspack integration does not use at runtime. Needs@meteorjs/rspack3, still in beta.Test plan
ingest:npm run test:unit→ 246 passingapp:meteor npm test→ 376 passing🤖 Generated with Claude Code