Repository navigation
fix(ci): allow the agent's generated MCP version file in the release-train scope check - #141
Merged
Merged
Conversation
…train scope check #102 moved the committed gen:version output from packages/mcp/src/version.ts to packages/agent/src/mcp/version.ts, but the Version PR scope allowlist still matched packages/*/src/version.ts. Every Version PR bumping @openrouter/agent now carries the moved file, so the train has rejected the Version PR on every scheduled run and nothing has released since 0.11.0. Replace the src/version.ts pattern with an exact list of generated version files, used by both the path allowlist and the content vet, so a file can't be allowed without having its lines checked against the gen-version.mjs output shape. Also fix the stale path in publish.yaml's comment. Co-Authored-By: Claude Code <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release train has failed every scheduled run (10-27, 10-29, 11-03), so nothing has shipped since
@openrouter/agent@0.11.0. Every run failed the same way:#102 moved the committed
gen:versionoutput frompackages/mcp/src/version.tstopackages/agent/src/mcp/version.ts, butverify-version-pr-scope.shstill only allowedpackages/*/src/version.ts. Any Version PR that bumps@openrouter/agentnow includes the moved file, so the check rejects it.Change
src/version.tspath pattern is replaced with an exact list,GENERATED_VERSION_FILES, which contains onlypackages/agent/src/mcp/version.ts.endswith("src/version.ts"), so a widened path pattern alone would have letsrc/mcp/version.tsthrough without checking its contents. Now a file can't be allowed without also being checked.packages/*/src/version.tspattern is gone; no package commits a file there anymore.publish.yamlcomment is fixed. No workflow behavior changes.Testing
Diff scope OK. The script onmainfails with the same error the train hit.ghreplaced by a stub:src/mcp/version.ts+ consumed changeset)src/mcp/version.tssrc/mcp/version.tswith no inline patchsrc/file (src/mcp/handle.ts)packages/mcp/src/version.tspathpostinstalladded topackage.jsonAfter merge
The next train run (Tue/Thu 09:23 UTC) will gate and merge Version PR #119, or someone can run it by hand. #119 currently releases
@openrouter/agent1.0.0, because.changeset/drop-preliminary-results.mdismajor. Add therelease:holdlabel to #119 if that release isn't ready to go out with the next train.