Fix goofy 0.6.7 and 0.6.7.0 in plugin driver version dropdown - #393
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup-ish to #385. When adding the latest version, check if that version with a
.0on the end already exists (or that the exact version already exists).Plugins should always be assigning a 4 part version number. Simple way of checking this avoiding doing any real work like actually extending the version number to the expected 4 part before adding it. It's probably fine that we might not always have the exact 4 part version when a new OTD version is released before any plugins are added for it.
Could also go the other way around with this. Removing the plugin metadata version and replacing it with
0.6.7. Not sure if that makes sense here.