Skip to content

Fix Zizmor Issues: Revert "Ci/simplify workflows (#66)" - #67

Merged
dmkarthi merged 1 commit into
OpenVisualCloud:devfrom
roshan-ku:revert-66-dev
Sep 30, 2026
Merged

dmkarthi merged 1 commit into
OpenVisualCloud:devfrom
roshan-ku:revert-66-dev

Conversation

@roshan-ku

@roshan-ku roshan-ku commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

This reverts commit 78d26b9.

Description

StepSecurity false positive, not a GitHub Actions error.

uses: $/.github/actions/analysis/coverity is the new GitHub self-repository syntax. GitHub resolves it to the exact commit currently running, so it is inherently pinned. It requires runner 2.336.0+.

StepSecurity has not recognized $/... yet and incorrectly classifies it as an unpinned third-party action. Do not add @sha; that would defeat the self-repository syntax and may be invalid.

Recommended action: keep the $/... references and suppress or ignore this StepSecurity finding until StepSecurity adds support. Reverting to ./... would satisfy StepSecurity but reintroduce the zizmor findings.

Checklist

Code Quality

  • Code follows project style guidelines
  • No unnecessary debug logs or commented-out code
  • No hardcoded values / secrets

Testing

  • Unit test added/modified accordingly
  • Perform manual basic sanity testing at system level

Review Readiness

  • PR title and description are clear and meaningful
  • Story/Task IDs are linked

Documentation

  • README or relevant docs updated (if applicable)

Security

  • No sensitive data exposed (keys, passwords, tokens)
  • Input validation added where needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Testing
  • Other... Please describe:

@roshan-ku roshan-ku changed the title Revert "Ci/simplify workflows (#66)" Fix Zizmor Issues: Revert "Ci/simplify workflows (#66)" Sep 30, 2026

@dmkarthi dmkarthi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmkarthi
dmkarthi merged commit 96af26b into OpenVisualCloud:dev Sep 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants