Repository navigation
Fix user input continue - #1067
MakinoharaShoko wants to merge 1 commit into
Conversation
确认输入后先 unmountPerform，带 -continue 时会触发一次 goNextWhenOver， 随后又手动 continueSentence，导致推进两次。改为演出始终声明 goNextWhenOver，由卸载统一触发继续。
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying webgal-dev with
|
| Latest commit: |
1f3c1e9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f382ec2.webgal-dev.pages.dev |
| Branch Preview URL: | https://fix-user-input-continue.webgal-dev.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f3c1e90f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| blockingAuto: () => true, | ||
| blockingStateCalculation: () => true, | ||
| // 确认输入后总是继续，无论是否带 -continue | ||
| goNextWhenOver: true, |
There was a problem hiding this comment.
When a normal getUserInput is immediately followed by another getUserInput, confirming the first now skips the second prompt. unmountPerform('userInput') synchronously invokes goNextWhenOver, so the next prompt is started and appended with the same perform name while the original unmountPerform loop is still running; that loop then encounters the newly added perform, unmounts it, and advances again without collecting its value. Continue only after unmountPerform has returned, or ensure the controller processes only the performs present when unmounting began.
Useful? React with 👍 / 👎.
fix #1065