Repository navigation
Retain NumPy 2.5 ceiling while raising supported floor - #9
Conversation
Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v1.26.0...v2.4.4) --- updated-dependencies: - dependency-name: numpy dependency-version: 2.4.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
OptimumAF
left a comment
There was a problem hiding this comment.
The proposed numpy>=2.4.4,<3.0 drops current master's intentional <2.5 limit. requirements.txt records that NumPy 2.5 stubs use Python 3.12 type-alias syntax and must stay excluded for the Python 3.11 mypy target. Refresh against current master while preserving that explanation, Pillow, and all other current requirements; use numpy>=2.4.4,<2.5. Keep dated experiment constraints unchanged. The old two-job CI predates the current five-job platform/CPU checks, so it is not current-base validation.
OptimumAF
left a comment
There was a problem hiding this comment.
Reviewed exact repaired head 18110ef. This resolves my prior requested change: numpy>=2.4.4,<2.5 preserves the Python 3.11 mypy explanation, Pillow and all other current requirements. The dated constraints blob063f067f0115ff22f1f5dc5039bb35b47ee76674 and environment blob37913942414f50e97766f4ece6cf5fa816612fad are unchanged. All five current-head CI jobs passed, including Windows native and Torch CPU. No historical repin or scientific/runtime authority is introduced.
Raise the supported NumPy minimum to 2.4.4 while retaining <2.5, so Python 3.11 mypy can parse the installed stubs. Synchronize current master to retain the compatibility comment and Pillow requirement and resolve the outdated branch conflict.
Source readback confirms a one-line requirements.txt diff against current master and exact original dated constraint/environment files. No historical snapshot is repinned and no clean-install or scientific acceptance claim is added. Current-head CI is required before merge.