Repository navigation
Handle dynamic non-string type-name metadata - #146
Merged
Essoz merged 7 commits intoOct 26, 2026
Merged
Conversation
Essoz
merged commit Oct 26, 2026
dc677be
into
codex/torchscript-builtin-identity
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch's dynamic
OpsWrapperreturns functions for__qualname__and__name__. TrainCheck rejected the former but accepted the latter, then failed its string assertion; this blocked fresh MNIST trace collection before the first training step.Validate the fallback
__name__as a nonempty string before using it. Preserve valid name precedence and the existing reported__class__fallback, and avoid truth-testing non-string metadata. This is a one-line production change stacked on #143.Validation:
OpsWrapper.Reproduction and compact before/after evidence:
docs/experiments/dynamic-type-names.mdanddocs/experiments/dynamic-type-names-results.json.Engineering hardening
Typed
typename(object, bool) -> strand its test helpers, preserving the fallback guards and final assertions (b64023b). Two added negative tests verify invalid fallback metadata still fails and metadata access exceptions propagate. All 37 combined tracing/TorchScript/type-name tests pass, as do pinned hooks and stronger scoped Mypy 1.9 checks.utils.pyretains its one pre-existing stronger-check stub diagnostic; no new ignores, casts, or relaxed assertions were introduced.Separately composed updated production sources pass 140 affected Linux regression tests, whole-source Mypy (77 files), Ruff, and isort. Whole-source Black still reports three unchanged legacy files, down from six in the original base; changed-file hooks pass. Strict checks are scoped and do not establish repository-wide strict typing. Historical performance numbers above retain their original measured revisions; this hardening pass does not re-estimate them.
Integration with current main
Based on #143 (
codex/torchscript-builtin-identity), with signed merge checkpoint43fe5065656e. The shared base is #150, which reconciles Daniel's parallel-inference tip122e769with mained54c7d. History is preserved; no force push or GitHub PR merge was used. All nine PR heads merge cleanly with their declared bases and current main, and the full stack composes without conflicts.The resolved composition passes 140 production + 28 harness tests locally (Python 3.10.16 / Torch 2.2.2), pinned Mypy over 77 production files, and stricter Mypy over 9 harness/test files. Conflict-file commit hooks pass. Full-stack Ruff/Mypy/isort pass; Black retains the same three pre-existing formatting failures (
config.py,proxy_wrapper/hash.py,proxy_wrapper/subclass.py). Remote CI is ignored because the self-hosted runner is unavailable. These checks validate integration; existing performance measurements retain their original revisions and are not remeasured here.Land the parent in main first, then retarget this PR to main before merging it. Repeat for its children. Use merge commits to preserve stack ancestry, or refresh descendants after a squash/rebase merge. Exact heads and local logs are retained in
outputs/conflict-resolution-20261026/.