Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh-run validation currently cannot distinguish real
ConsistencyRelationchecks from dormant or skipped variable rules: the coverage observer reports that family as unsupported, while the legacy checker can return success when no comparable variable values were observed.This extends the validation observer to count the actual checker's collected overlapping variable-value pairs and completed comparisons, without replacing its predicates or learning rules. It records exact variable identities, timestamps/liveness bounds, required types/attributes, precondition results, skipped checks and unvisited pairs. Missing variable types or attributes remain dormant/unvalidated; failed pair collection leaves the opportunity count unknown rather than turning it into zero. API-call counts are explicitly inapplicable to variable-only rules. The observer validates its expected source structure and fails visibly if the checker changes.
Coverage output schema advances from 2 to 3.
fully_validated_activemeans an active checker completed, not that it was violation-free or exhausted all candidates; consumers must also inspectcheck_passedand unvisited counts. Production inference and checking behavior are unchanged.Validation:
6dccb47as unsupported coverage and pass with this change. Cases include real passes and violations, missing required attributes/types, malformed identities, comparison errors, interrupted collection and observer/directCheckerResultequality.--check-untyped-defs --disallow-untyped-defs --disallow-any-generics.This is validation tooling, not a performance optimization. It does not establish model-tracer/FSDP compatibility or claim that variable invariants ran in the separate API-only Llama pilot. The signed commit targets main independently; there is no stacked PR base dependency.