Skip to content

Consolidate and harden all open envctl changes - #342

Merged
kfiramar merged 32 commits into
devfrom
integration/consolidate-open-prs-20260711
Jul 12, 2026
Merged

kfiramar merged 32 commits into
devfrom
integration/consolidate-open-prs-20260711

Conversation

@kfiramar

@kfiramar kfiramar commented Jul 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Consolidates #335, #336, #337, and #341 into one integration branch targeting dev. Every source head and merge commit remains in history, followed by a cross-feature hardening pass focused on ownership, cancellation safety, deterministic state, and leak-free lifecycle behavior.

What changed

  • Hardened startup, resume, restart, stop, and cleanup around explicit ownership, immutable revisions, atomic persistence, scoped leases, and fail-closed recovery.
  • Prevented repeated or concurrent starts from orphaning old processes, containers, listeners, port locks, or state while preserving sibling projects and foreign owners.
  • Added Docker service launch-token identity, delayed-create recovery, immutable-ID cleanup, name-reuse protection, cancellation safety, and secret env-file scrubbing.
  • Made process and service handoffs transactional: listeners and containers must be confirmed and recorded, or cleanup authority remains durable for reconciliation.
  • Made envctl the PR-preview owner and fixed Pele PR #410's missing-python failure with a private validated Python 3 compatibility shim that does not modify imported worktrees.
  • Added deterministic multi-project/service targeting and extracted repository-wide cleanup into a focused owner module while keeping lifecycle state fail closed.
  • Changed PR base selection to prefer dev, then fall back to main, then master.
  • Hardened shipping against transiently empty GitHub check rollups and made contributor CI target the dev workflow correctly.

Review closure

All 30 historical inline review threads are resolved, with no actionable comment remaining:

The only top-level #342 comment is an informational Codex usage-limit notice.

Validation

Final envctl test-focused --ship-on-pass gate on head 7194164f7b98d7e6073d0e6a985bad9958ffb8d6:

  • planning: 564 passed, 100 subtests passed
  • actions: 573 passed, 49 subtests passed
  • startup: 512 passed, 25 subtests passed
  • runtime: 1,204 passed, 15 skipped, 338 subtests passed
  • shared: 279 passed, 168 subtests passed
  • UI: 554 passed, 42 subtests passed
  • release shipability: 21 passed
  • Ruff: passed for every changed Python and test file
  • GitHub Actions: pytest, Ruff, and build & shipability all passed on the final head

Additional adversarial/E2E proof:

  • Replayed Pele PR #410 head b1bfff94be9d; the preview voice runtime started through the Python compatibility shim.
  • Repeated process start reused the same PID; restart terminated the old PID; invalid selectors caused no mutation; sibling state survived; cleanup left zero target listeners, locks, or PIDs.
  • Docker scenarios covered delayed creation, timeout and interrupt boundaries, token discovery, immutable-ID removal, name reuse, foreign-scope refusal, and env-secret cleanup; final inventory had zero managed containers or secret env files.
  • Clean-room wheel verification passed with 664 packaged entries, a fresh Python 3.13 install/import, resource loading, CLI help, and dependency inspection.

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

kfiramar added 27 commits July 11, 2026 00:40
Integrate the reviewed preview-controller ownership changes into the open-PR consolidation sidebranch.
Integrate the reviewed cleanup and targeting changes into the open-PR consolidation sidebranch.
Integrate the reconciled runtime/state refactor and deleted-file ship hardening into the open-PR consolidation sidebranch.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

kfiramar added 2 commits July 12, 2026 00:13
Integrate the fully reconciled and CI-verified Docker runtime into the open-PR consolidation sidebranch.
@kfiramar kfiramar changed the title Integration/consolidate open prs 20260711 Consolidate and harden all open envctl changes Jul 11, 2026
@kfiramar
kfiramar changed the base branch from main to dev July 11, 2026 21:45
@kfiramar
kfiramar merged commit 2796a6e into dev Jul 12, 2026
3 checks passed
@kfiramar
kfiramar deleted the integration/consolidate-open-prs-20260711 branch July 12, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant