Skip to content

Report PR preview provisioning immediately - #353

Merged
kfiramar merged 1 commit into
mainfrom
codex/preview-controller-feedback
Jul 16, 2026
Merged

kfiramar merged 1 commit into
mainfrom
codex/preview-controller-feedback

Conversation

@kfiramar

@kfiramar kfiramar commented Jul 16, 2026 •

Copy link
Copy Markdown
Collaborator
  • Report PR preview provisioning immediately (e2fab46)

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@kfiramar
kfiramar merged commit 2bb9239 into main Jul 16, 2026
3 checks passed
@kfiramar
kfiramar deleted the codex/preview-controller-feedback branch July 16, 2026 07:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2fab466a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +2827 to +2831
if (
state
and state.status == "stopped"
and state.label_added_at == isoformat(active_since)
):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retry cleanup before dropping stale preview labels

When a PR still has the preview label but the saved state is already stopped, this branch now removes the label without calling stop() again. That loses the only retry path for best-effort cleanup that stop() performs but does not record failures for, such as remove_public_routes() and mark_deployment_inactive(); for example, after a manual/TTL stop saved stopped but Docker route removal or the GitHub deployment-status API failed transiently, the next sweep will drop the label and leave stale public routes or an active deployment instead of retrying cleanup.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant