Repository navigation
Report PR preview provisioning immediately - #353
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2fab466a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| state | ||
| and state.status == "stopped" | ||
| and state.label_added_at == isoformat(active_since) | ||
| ): |
There was a problem hiding this comment.
Retry cleanup before dropping stale preview labels
When a PR still has the preview label but the saved state is already stopped, this branch now removes the label without calling stop() again. That loses the only retry path for best-effort cleanup that stop() performs but does not record failures for, such as remove_public_routes() and mark_deployment_inactive(); for example, after a manual/TTL stop saved stopped but Docker route removal or the GitHub deployment-status API failed transiently, the next sweep will drop the label and leave stale public routes or an active deployment instead of retrying cleanup.
Useful? React with 👍 / 👎.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.