Complete DayZ Workshop updates without Minecraft version detection - #293
Open
deadpool311 wants to merge 5 commits into
Open
Complete DayZ Workshop updates without Minecraft version detection#293deadpool311 wants to merge 5 commits into
deadpool311 wants to merge 5 commits into
Conversation
Builds on the inactive implementation from PR Osiris-Team#290, with Workshop consumer app-id resolution and stricter SteamCMD success handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #215 by building on #291's Steam Workshop updater and removing the Minecraft-version prerequisite for dedicated servers such as DayZ.
This preserves meta.cpp discovery, Steam consumer app-ID lookup, SteamCMD downloads, update profiles, and cached Steam versions from #291. Additional changes defer Minecraft version detection until a Modrinth/CurseForge lookup needs it, correctly assign the server-version fallback, and reject unknown Workshop profiles before downloading or installing.
The tests use a non-JAR dedicated-server fixture without Minecraft overrides, cover invalid/MANUAL/NOTIFY profiles, and close the fixture logger for Windows cleanup.
Validation: JDK 17.0.20.1, Maven 3.9.11,
mvn -B -Dtest=SteamWorkshopModTest,SteamCMDTest#buildsWorkshopItemCommand test: 8 tests, 0 failures, 0 errors. The same tests against unchanged #291 production code produce 1 failure and 2 errors, including the Minecraft-version failure.git diff --checkpasses. Full suite and live DayZ/Steam downloads have not been tested; Steam interactions are mocked. Background YAML watcher callbacks still logStream closedduring test cleanup without failing the focused suite.Attribution: this derives from SemHiel2003's #291 (commit 3d2041c), itself based on #290 and #280. The Minecraft-version blocker was previously reported by matiascamaran in #215 with https://gist.github.com/matiascamaran/19bcbc3669675956d25c73c6716de777; I do not claim original discovery of that blocker.
AI disclosure: the additional code and tests were generated with Codex assistance. I reviewed the prepared contribution and results and approved submission. The automated tests were run by Codex; I am not claiming a human-operated live DayZ test. I understand this is a derived bounty submission subject to maintainer acceptance and the original-contributor grace period.