You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this really sufficient? I would have expected the entire pcre2test block to be conditional, not just the final command to install it.
Yes, because without the link to the root of the build tree this a free-floating leaf, and nothing gets executed for it for the actual build.
Of course, I could make all code that deals with pcre2test* conditional. Then we need an optional var and more if-statements because it gets referenced later for posixlib. I can do it like this if you prefer.
I think I understand. Zig build has no all target like a conventional build system. The b.default_step for no-arg zig build is zig build install, and that target only pulls in objects from the tree linked by b.installArtifacts().
My mental model was based on make; make install where there's a step for build targets (all libs/exes) and the 'install' step is an extra thing afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1041