Repository navigation
Fix wrong type cast - #1060
Open
zherczeg wants to merge 1 commit into
Open
Fix wrong type cast#1060zherczeg wants to merge 1 commit into
zherczeg wants to merge 1 commit into
Conversation
carenas
suggested changes
Oct 31, 2026
| /* We temporarily encode the needs_control_head in the lowest bit. | ||
| The real value should be short enough for this operation to work | ||
| without triggering Undefined Behaviour. */ | ||
| data = (int)((short)((unsigned short)framesize << 1) | (needs_control_head ? 1 : 0)); |
Contributor
There was a problem hiding this comment.
should update the ASSERT above to match
Found by Aram Zahedi
Member
|
This one requires a backport, I believe. |
Collaborator
Author
|
Not much work needed. Added recently by a clang patch: #344 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by Aram Zahedi