HLS encoder profiles - #271
Merged
Merged
Conversation
farski
approved these changes
Sep 30, 2026
farski
left a comment
farski
left a comment
Member
There was a problem hiding this comment.
I didn't dig into all the various encoder flags and options that this touches, but the general approach to modularizing encoders feels solid. Appreciate the extensive commenting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for different encoders like x264 (the default), but also using video toolbox if you're on Apple silicon, or more to the point, using
h264_nvencandcudaif there's an Nvidia gpu available.Controlled by an env var to indicate which encoder to use, a default in the preset, and a couple of checks to make sure ffmpeg will support the encoder.
Also, fixed the ffmpeg calls to look more like the transcode job, so it uses open3 now to capture stdout and stderr separately, and logs the full output when there is an error, so we can debug this thing.