Skip to content

fix(registrar): save the captured beneficiary photo on registration - #91

Open
gkbishnoi07 wants to merge 1 commit into
angular-zard-migrationfrom
fix/registration-save-beneficiary-image
Open

fix(registrar): save the captured beneficiary photo on registration#91
gkbishnoi07 wants to merge 1 commit into
angular-zard-migrationfrom
fix/registration-save-beneficiary-image

Conversation

@gkbishnoi07

@gkbishnoi07 gkbishnoi07 commented Sep 10, 2026

Copy link
Copy Markdown

QA reference

Part of point 5 in the MMU-UI QA testing doc:

"The image we have taken and registered is not visible in the Nurse module."

This PR is the save side of that fix (the display side is a paired MMU-UI PR).

Root cause

The migration's rewritten iEMRForm() payload builder dropped the image field. Old main sent benImage: personalForm.image (+ changeInBenImage), but the migrated payload sent nothing — so the captured photo was never stored, and appeared as "Image not found" everywhere.

Changes

  • registration.component.ts — restore benImage (+ changeInBenImage) in the registration payload, read from the image / imageChangeFlag controls.
  • personal-information.component.ts — add the missing imageChangeFlag control. It was being patchValue'd on capture but never existed as a control, so the "image changed" flag silently did nothing (matters for the edit/revisit flow).

Verified

After this change the getBenImage response returns the stored base64 photo, and it renders in the nurse worklist view / thumbnail / profile (with the paired MMU-UI display fixes).

Paired PR

MMU-UI PR (worklist read path, camera-dialog viewer, profile read path, worklist thumbnail) + the Common-UI pointer bump.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 865b1609-f1c1-46af-9449-455be90563c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gkbishnoi07
gkbishnoi07 force-pushed the fix/registration-save-beneficiary-image branch from bfc6ecf to f9a9ec9 Compare September 10, 2026 18:22
…hoto

the migration dropped benImage from the registration payload, so the
captured photo was never stored and showed as "not found". restore benImage
(and changeInBenImage) in the payload and add the missing imageChangeFlag
control. also fix the search-result image view to read the photo from the
wrapped response (data.data.benImage).

fixes MMU-UI QA testing point 5 (registrar side).
@gkbishnoi07
gkbishnoi07 force-pushed the fix/registration-save-beneficiary-image branch from f9a9ec9 to 5a86751 Compare September 10, 2026 18:28
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant