Add getInstrument method to BlockData/BlockType

[ItzMatick]

I added the missing getInstrument() method to the API as requested in issue #14228.

Changes:

• Added the interface method to BlockData.
• Added the translation logic in CraftBlockData.

[Lulu13022002]

This only really depends on the block type so I think BlockType is a more suitable place

[ItzMatick]

That’s a fair point, but I added it to BlockData because it directly mirrors Vanilla architecture (this.state.instrument()). If I move it to BlockType, I would have to pull it from default blocks.

[ItzMatick]

@Lulu13022002 What do you think? Where should I put it?

[Lulu13022002]

I think it can be on both if you really want it on BlockData, but it's fine to use the default block state (it wouldn't be the first method here). There is no need to fully mirror vanilla, the api is a bit inconsistent on where to place things here (some case using CraftBlock too).

[ItzMatick]

Sure, I added it also to BlockType.

[ItzMatick]

Okay, I added anotation and removed comments. Should I do something about build failure with the previous commit, or is that ok?

[Doc94]

Okay, I added anotation and removed comments. Should I do something about build failure with the previous commit, or is that ok?

I rerun the build and all looks good by the moment.

[Lulu13022002]

Looking into this there's a conflict with NoteBlock#getInstrument so I'm not sure about block data.