Repository navigation
[DO NOT MERGE] Spike interface for managing timeouts - #3166
Draft
SzymonPobiega wants to merge 1 commit into
Draft
SzymonPobiega wants to merge 1 commit into
SzymonPobiega wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServicePulse gets a Timeouts area that lists saga timeouts reported to ServiceControl and lets an operator reschedule, trigger, or cancel a pending timeout.
The design is in docs/saga-timeout-management-design.md in Particular/ServiceControl#6025, which also implements the API this page calls. The endpoint side is Particular/NServiceBus#7996. ServicePulse never changes a timeout directly: an action sends a request through ServiceControl to the endpoint, and the page shows the result when the endpoint reports it.
Changes
GET /api/timeoutsthroughapiRoutes.ts. Its badge shows the overdue count when it is above zero./timeoutswith Pending, Overdue, and All tabs, a search and filter bar, and a paged table: due time, timeout, saga and correlation value, last change with its source, and status. It refreshes every 5 seconds./timeouts/:timeoutIdshows the details, the payload, the history, and the other timeouts of the saga instance. A reschedule that keeps the previous due time is labeled "Payload updated".Unknowntimeouts and for requests with no response after 10 minutes.timeoutsmock scenario simulate an endpoint that applies requests after 3 seconds, sonpm run dev:mocksshows the pages.Deviations from the design
Verification
npm run type-check, ESLint, andvite buildpass.test/mocks/platform-health-state.spec.ts, which also fails onmaster.NODE_OPTIONS=--experimental-strip-types./apiproxy. The API calls the page makes were exercised end to end; the pages were not checked in a browser.🤖 Generated with Claude Code