Fix Price item searches from encoded and compressed trade URLs - #2506
Open
Kanaxai wants to merge 4 commits into
Open
Fix Price item searches from encoded and compressed trade URLs#2506Kanaxai wants to merge 4 commits into
Kanaxai wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Clicking "Price item" with a working trade website URL can return HTTP 404. Encoded league names are escaped a second time (
Forbidden%20RitesbecomesForbidden%2520Rites), and gzip/base64url share queries are sent to the saved-search lookup endpoint as if they were search IDs.Decode the league path segment before building API URLs. Decode compressed share queries locally, wrap the filters in the API query object, and submit them through the existing search/fetch flow. Preserve weight sorting and saved-search URL support, and return errors for invalid URLs or malformed queries. The gzip decoder uses the existing zlib library through LuaJIT FFI with a 1 MiB output limit.
Steps taken to verify a working solution: