Add support for Runeforged/mastered unique variants - #2511
Draft
vaisest wants to merge 1 commit into
Draft
Conversation
vaisest
marked this pull request as draft
September 8, 2026 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This adds support for runeforged/mastered base variants in the unique DB by adding a new
{base:n}variant tag. This works similarly to variants, but is treated as its own group, similar to what has been done with unique versions. This should also work with versioning:This is still not yet fully implemented. For example the dropdown in the above example doesn't update correctly, and the functionality of adding the runemastered base to a unique which already has base variants needs testing. PoB2 currently seems to have no uniques with base variants.
Currently this defaults to the last base variant, which is runemastered in most cases. I think it's a good idea for sorting purposes, but this needs more work, since lvl > 55 uniques can also be runeforged, but they will convert some defences to ward, instead of being a pure benefit.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: