Tests branch update to upstream HEAD - #10330
Closed
Paliak wants to merge 134 commits into
Closed
Conversation
This reverts commit 3ea5a77.
Quote variables. Instead of using a sub shell built in bash functionality is now used to strip non ascii characters from the build link generating a string that will be used as a filename. The dawidd6/action-download-artifact is known to allow for creation of vulnerable workflows. This workflow does not execute any code coming from artefacts. I've additionally added paths everywhere to harden against symlinks as suggested in the following link: https://www.legitsecurity.com/blog/github-actions-that-open-the-door-to-cicd-pipeline-attacks
To avoid the vulnerability mentioned in aa34d46 the artefact is unpacked into a dedicated directory in /tmp
as base for generation of newer build lists in case there isn't enough new builds.
Contributor
Author
|
Whelp... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.