Restore cluster allocations correctly during undo and redo - #10332
Open
AdamZ-8113 wants to merge 1 commit into
Open
Restore cluster allocations correctly during undo and redo#10332AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Cluster jewel passives/notables could accidentally be restored due to broken "undo" logic. After unallocating cluster jewel passives, then making a change elsewhere on the tree (add or remove nodes), pressing Ctrl+Z would undo the tree changes and reallocate the cluster nodes -- even if they were removed several changes earlier.
This makes Undo and Redo restore the cluster allocations from the correct step, without bringing back older remembered allocations. It also makes sure the starting Undo history includes the cluster nodes loaded from a saved build, and that nested clusters are rebuilt when their sockets are restored.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: