Respect spell cooldowns for traps/mines while calculating DPS - #10335
Open
AdamZ-8113 wants to merge 1 commit into
Open
Respect spell cooldowns for traps/mines while calculating DPS#10335AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10334
Description of the problem being solved:
Skills supported by Trap, Blastchain Mine, or High-Impact Mine would calculate hit DPS using their throwing rate without checking the spell's cooldown.
This adds a check modeled after other similar checks in CalcOffence.lua. I believe Totems and other proxies are already properly supported.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pob.codes/b/WrERGRSB92V
Before screenshot:
After screenshot: