Skip to content

Deterministic xml: emit element attributes in sorted key order #10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rasmuskl wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −7
Open

Deterministic xml: emit element attributes in sorted key order #10337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions runtime/lua/xml.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,20 +117,27 @@ local function composeNode(frag, node, lvl)
t_insert(frag, '<')
t_insert(frag, node.elem)
if node.attrib then
local attribKeys = { }
for key, val in pairs(node.attrib) do
if val then
if type(key) ~= "string" then
return "invalid xml tree (attribute name in <"..node.elem.."> is not a string)"
elseif type(val) ~= "string" then
return "invalid xml tree (value for attribute '"..key.."' in <"..node.elem.."> is not a string)"
end
t_insert(frag, ' ')
t_insert(frag, key)
t_insert(frag, '="')
t_insert(frag, encodeContent(val))
t_insert(frag, '"')
t_insert(attribKeys, key)
end
end
table.sort(attribKeys)
for _, key in ipairs(attribKeys) do
local val = node.attrib[key]
if type(val) ~= "string" then
return "invalid xml tree (value for attribute '"..key.."' in <"..node.elem.."> is not a string)"
end
t_insert(frag, ' ')
t_insert(frag, key)
t_insert(frag, '="')
t_insert(frag, encodeContent(val))
t_insert(frag, '"')
end
end
if not node[1] then
t_insert(frag, '/>\n')
Expand Down
Loading