Export party buffs in name order - #10340
Open
rasmuskl wants to merge 1 commit into
Open
Conversation
PartyTab:exportBuffs walked the name-keyed buffExports maps, and the nested otherEffects map, with pairs(), so the text inside each <ExportedBuffs> element came out in string-hash order and differed between runs of the same build. Use pairsSortByKey for both walks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
PartyTab:exportBuffs walked the name-keyed buffExports maps, and the nested otherEffects map, with pairs(), so the text inside each element came out in string-hash order and differed between runs of the same build. Use pairsSortByKey for both walks.
Steps taken to verify a working solution:
Ran against my own test suite and has been running in poe.ninja for a few days.