Fix/tincture preview and range dropdown - #10341
Open
AdamZ-8113 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10322
Description of the problem being solved:
Tincture item previews show base modifier values without applying quality or local increased effect. This change makes the preview show the correct effect while keeping the original range in the crafting controls and saved item text. This change is purely cosmetic, the actual damage calculation was already correct.
This also fixes a crash when editing an imported tincture. Changing an affix could leave old modifiers in the range dropdown, and selecting one could crash PoB. The dropdown now updates after each change.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pob.codes/b/7wLTYKOtVhv
Before screenshot:
After screenshot: