Repository navigation
improve: refactor player - #250
Draft
ToddyTheNoobDud wants to merge 3 commits into
Draft
ToddyTheNoobDud wants to merge 3 commits into
ToddyTheNoobDud wants to merge 3 commits into
Conversation
Some things are still overfilled, not properly documented, some responsibilities remain coupled ( Event handling also triggers lyrics loading and mixer cleanup ) This is just a initial progress with no behavior change, the only thing changed was a fix for crossfade which a seek request made it fail. All of this will be properly documented, re-organized, and will be cleaner for you and i to read, slowly making progress.
Group player code into tracks, audio, events, and features. Rename transitions to fading and recovery to monitor. Restore _realPosition() for the worker profiler. Prevent overlapping voice reconnects while preserving session changes during handshakes. Start pending playback once when voice becomes ready.
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Write here about the changes you've made
Why
Write here why you think this should be merged
Checkmarks
Additional information
Some things are still overfilled, not properly documented, some responsibilities remain coupled ( Event handling also triggers lyrics loading and mixer cleanup )
This is just a initial progress with no behavior change, the only thing changed was a fix for crossfade which a seek request made it fail.
All of this will be properly documented, re-organized, and will be cleaner for you and i to read, slowly making progress.
(This desing is not guaranteed to be final one, probaly we will have more conversations in whats gonna be changed etc. I'll keep updating this message whenever something changes and why it changed, so we can keep tracking)
The current player api (dev branch) should be preserved on this