Repository navigation
fix(tests): drop the empty [[package]] left in the next-app-route fixture lock (tokio-ban KeyError) - #14593
Closed
raliclo wants to merge 1 commit into
Closed
fix(tests): drop the empty [[package]] left in the next-app-route fixture lock (tokio-ban KeyError)#14593raliclo wants to merge 1 commit into
raliclo wants to merge 1 commit into
Conversation
…ture lock PerryTS#14482 removed the perry-uuid entry from tests/integration/release/packages/next-app-route/provider/Cargo.lock by hand and kept its `[[package]]` header, so two headers sat back to back. TOML reads that as a package table with no keys, and `scripts/tokio_inventory.py --offline` (the `tokio-ban` job) dies on `package["name"]` with KeyError on every PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
 |
This was referenced Nov 13, 2026
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokio-banfails on every PR withKeyError: 'name'inscripts/tokio_inventory.py. #14482 removed theperry-uuidentry from the release-integration fixture lock by hand and left its[[package]]header behind, so two headers sit back to back; TOML parses that as a package with no keys. This PR deletes the stray header.Changes
tests/integration/release/packages/next-app-route/provider/Cargo.lock: remove the empty[[package]]line (one line).Related issue
Introduced by #14482. No other lockfile in the tree has an entry without
name/version(checked all 27 trackedCargo.lockfiles withtomllib).Test plan
On
f451fa6139(currentmain), the three steps of thetokio-banjob:mainpython3 scripts/tokio_inventory.py --self-testpython3 tests/tooling/infrastructure/test_tokio_gate.pypython3 scripts/tokio_inventory.py --offlineKeyError: 'name'(exit 1)tokio ban: 115 manifests, 27 lockfiles and Rust sources clean (offline)(exit 0)No
changelog.dentry: the change is outsidecrates/and is CI-only churn.Checklist
feat:/fix:/docs:/chore:prefix convention used in the log🤖 Generated with Claude Code
https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p