You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(wasm): the global isNaN / isFinite coerce their argument - #14619
On --target web, the global isNaN and isFinite do not apply ToNumber: isNaN("abc") and isNaN(undefined) are false, isFinite("1") is false (Node: true for all three). Expr::IsNaN / Expr::IsFinite — produced only by the global functions — use the is_nan / is_finite bridges, which implement the non-coercing Number.isNaN / Number.isFinite. Listed in #14595.
Changes
wasm_runtime.js: global_is_nan / global_is_finite bridges that call the global functions.
28 pass / 4 fail, same set (no case uses isNaN / isFinite)
The integration suite ran before the final rebase onto 46b2339d82; the unit tests were re-run after it. Built on macOS (Apple M6), nightly from rust-toolchain.toml, LLVM 23.1.5, Node 26.13.1. rustfmt --check on the touched Rust files.
Checklist
I have NOT bumped the workspace version or edited CHANGELOG.md
My commits follow the loose feat: / fix: / docs: / chore: prefix convention used in the log
I've read CONTRIBUTING.md and agree to the Code of Conduct
Under the web target, global isNaN and isFinite now coerce inputs like their JavaScript counterparts, so values such as strings and undefined produce the expected results.
`Expr::IsNaN` and `Expr::IsFinite` (the global `isNaN` / `isFinite`, their
only producers) used the `is_nan` / `is_finite` bridges, which implement the
non-coercing `Number.isNaN` / `Number.isFinite`. So on the web target
`isNaN("abc")` and `isNaN(undefined)` were false and `isFinite("1")` was
false. They now call `global_is_nan` / `global_is_finite`, which apply
ToNumber. `is_nan` / `is_finite` keep their meaning for their other users
(`IsUndefinedOrBareNan`, and `Number.isNaN` / `isFinite`).
`global_is_nan_and_is_finite_coerce_like_node` prints the non-coercing answers
(`false false false true false` / `false false false true`) with the old
bridges.
Refs PerryTS#14595.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
No actionable comments were generated in the recent review.
Walkthrough
For --target web, global isNaN and isFinite expressions now use dedicated runtime bridges that apply JavaScript’s coercing global functions. A semantics test covers string, undefined, NaN, Infinity, and finite-number inputs.
The runtime dispatch adds global_is_nan and global_is_finite, and string collection interns both bridge names.
Use bridges for global expressions crates/perry-codegen-wasm/src/emit/expr/regex_globals.rs, crates/perry-codegen-wasm/src/emit/tests.rs, changelog.d/14619-wasm-global-isnan-isfinite.md
Global isNaN and isFinite expressions call the new bridges. The semantics test checks coercion results, and the changelog records the bridge change.
With --target web, global isNaN and isFinite now coerce their arguments the way Node does. Number-specific checks keep their existing non-coercing behavior. No actionable merge risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: the WebAssembly target's global isNaN and isFinite now coerce their arguments. The changeset adds global_is_nan and global_is_finite bridges and routes Expr::IsNaN and…
Description check
The description covers the summary of the bug and fix, the changes per file, the related issue, and the test plan. It does not follow the template's structure exactly. It omits the template's checklis…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the WebAssembly target's global isNaN and isFinite now coerce their arguments. The changeset adds global_is_nan and global_is_finite bridges and routes Expr::IsNaN and Expr::IsFinite through them, so the title matches the change. The title follows the fix(wasm): prefix convention.
Full details: Description check
Explanation
The description covers the summary of the bug and fix, the changes per file, the related issue, and the test plan. It does not follow the template's structure exactly. It omits the template's checklist items for cargo build --release and the workspace test command with the exclusions, and it does not list whether a fixture under tests/fixtures/programs/ was added or whether docs/src/ was considered. The Related issue section says 'Refs #14595', which matches the template format. The Summary runs to about three sentences, which exceeds the template's one-or-two-sentence guidance. The description is mostly complete, so it passes.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
--target web, the globalisNaNandisFinitedo not apply ToNumber:isNaN("abc")andisNaN(undefined)arefalse,isFinite("1")isfalse(Node:truefor all three).Expr::IsNaN/Expr::IsFinite— produced only by the global functions — use theis_nan/is_finitebridges, which implement the non-coercingNumber.isNaN/Number.isFinite. Listed in #14595.Changes
wasm_runtime.js:global_is_nan/global_is_finitebridges that call the global functions.emit/expr/regex_globals.rs:Expr::IsNaN/Expr::IsFinitecall them.is_nan/is_finitekeep their non-coercing meaning forIsUndefinedOrBareNanand forNumber.isNaN/Number.isFinite(fix(wasm): Number.isNaN / isFinite / isInteger / isSafeInteger on the web target #14615).emit/string_collection.rs: interns the two names.emit/tests.rs:global_is_nan_and_is_finite_coerce_like_node.Related issue
Refs #14595.
Test plan
Base
46b2339d82(currentmain).false false false true false/false false false truenode --experimental-strip-typescargo test -p perry-codegen-wasmtests/integration/wasm/run_wasm_tests.shisNaN/isFinite)The integration suite ran before the final rebase onto
46b2339d82; the unit tests were re-run after it. Built on macOS (Apple M6), nightly fromrust-toolchain.toml, LLVM 23.1.5, Node 26.13.1.rustfmt --checkon the touched Rust files.Checklist
feat:/fix:/docs:/chore:prefix convention used in the log🤖 Generated with Claude Code
https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
Summary by CodeRabbit
isNaNandisFinitenow coerce inputs like their JavaScript counterparts, so values such as strings andundefinedproduce the expected results.