You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: wasm32 runtime build (RecordArrayHeader), fmt, stale raw-handle ceilings, two integration expectations - #14631
Fixes the main reds that are mechanical, stale or a one-line layout pin, as #14604 did: wasi-execution (the runtime does not build for wasm32), lint → Check formatting, the stale entries of the raw-handle ratchet, and two wasm integration cases left behind by #14625. The GC-safety audits still red on main are untouched; they need their authors (see #14604).
Changes
commit
change
verified locally (macOS arm64)
3d1b0942ac
record_array.rs: the size_of::<RecordArrayHeader>() == 24 assertion (#14487) pinned the 64-bit layout and fails on wasm32 (E0080, the wasi-execution failure). It now pins four u32 counts then the pointer with no padding (16 + size_of::<*mut u64>()); the capacity (+4) and elems (+16) offset assertions stay. Nothing depends on the width: compiled code reaches the head only through the js_record_array_* entries, the GC through elems_slot (addr_of_mut!), and shape_rule3 needs only capacity at +4.
The header and both assertions compiled alone with the repo nightly for wasm32-wasip1 and aarch64-apple-darwin: the old assertion fails on wasm32 with the CI message, the new one holds on both. cargo test --release -p perry-runtime --lib record_array: 16 passed. The full wasip1 runtime build was not run here (needs wasi-sdk's clang); CI's wasi-execution is the check.
8b0a3fe3f9
cargo fmt --all: crates/perry-runtime/src/lib.rs landed unformatted after #14604.
cargo fmt --all -- --check OK
0ab35ab584
scripts/raw_handle_debt_files.txt: deletes the eleven per-module ceilings raw_handle_debt.py reports as "matches nothing -- DELETE its line" (global_this_webassembly.rs and ten test modules).
--no-raise-vs upstream/main: baseline 861 → 861, ceilings 107 → 96, none raised; no "matches nothing" left. (The summary of run_lint_gates.sh shows only the first of them; the gate itself lists all eleven.)
b5b3522be3
tests/integration/wasm/{20_string_from_char_code,22_cross_module_nested_object}.expected: #14625 made console.log(a, b) print one line, as Node does, but kept the old one-value-per-line expectations, so both cases fail on main. New contents are Node's output (the cross-module case run with explicit .ts imports).
The compiled programs print exactly Node's output; tests/integration/wasm/run_wasm_tests.sh back to 28 pass / 4 fail (10_higher_order, 11_map_set_json, 14_regex_date, 19_ffi_imports).
Test plan
BASE_SHA=<merge-base> SKIP_COMPILE_GATES=1 bash scripts/run_lint_gates.sh on this branch and on pristine main, FAIL sets compared: the branch fixes Check formatting and adds no FAIL. cargo clippy -p perry --bins exits 0. (Last full run on b58bade7ac; the commits since, up to edd8d7f5d3, touch none of this PR's files, and fmt / file-size / raw-handle were re-run on edd8d7f5d3.)
Three lint steps fail only on macOS and pass in CI: Windows type-check and npm staging (no MSVC SDK / llvm-objcopy), Array-type predicate lint self-test (BSD grep).
Checklist
I have NOT bumped the workspace version or edited CHANGELOG.md
My commits follow the loose feat: / fix: / docs: / chore: prefix convention used in the log
I've read CONTRIBUTING.md and agree to the Code of Conduct
`const _: () = assert!(size_of::<RecordArrayHeader>() == 24)` (PerryTS#14487) pins
the 64-bit layout; on wasm32 the `elems` pointer is 4 bytes and the head is 20,
so `wasi-execution` fails building the runtime for wasm32-wasip1 with E0080.
The head is reached only through the `js_record_array_*` entries and the GC
through `elems_slot` (`addr_of_mut!`), so nothing depends on the width: the
assertion now pins four u32 counts followed by the pointer with no padding
(16 + pointer size), keeping the capacity (+4) and elems (+16) offsets.
Checked by compiling the header and both assertions alone for
wasm32-wasip1 and aarch64-apple-darwin: the old one fails on wasm32 with the
CI message, the new one holds on both. `cargo test -p perry-runtime --lib
record_array`: 16 passed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
…hing nothing
raw_handle_debt.py lists eleven per-module ceilings whose module now has no
debt site ("matches nothing -- DELETE its line so the cleanup cannot be
undone"): global_this_webassembly.rs and ten test modules under
perry-runtime (gc/tests/..., node_stream_tests*.rs, node_submodules/test.rs).
Only those lines go; `--no-raise-vs upstream/main`: baseline 861 -> 861,
module ceilings 107 -> 96, none raised.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
…e output
PerryTS#14625 made `console.log(a, b)` print its arguments on one line, as Node does,
but left 20_string_from_char_code.expected and
22_cross_module_nested_object.expected in the old one-value-per-line form, so
tests/integration/wasm/run_wasm_tests.sh fails both on main. The new contents
are Node's output (the cross-module case run with explicit `.ts` imports), and
the compiled programs print exactly that; the suite is back to 28 pass / 4
fail with the long-standing set.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
No actionable comments were generated in the recent review.
Walkthrough
The changes update a runtime size assertion to account for pointer width, remove entries from the raw-handle debt allowlist, and revise two wasm integration output expectations. A changelog entry records these and other CI updates.
This change fixes the wasm32 size assertion, removes stale raw-handle ceilings, and updates two wasm output expectations. No actionable merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change set: a wasm32 runtime build fix for the RecordArrayHeader assertion, plus fmt, stale raw-handle ceilings, and two integration expectations. It is specific and matches t…
Description check
The description follows the template's Summary, Changes, and Test plan sections. It explains the purpose and lists each commit with a verification note. The template's Related issue section is not pre…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change set: a wasm32 runtime build fix for the RecordArrayHeader assertion, plus fmt, stale raw-handle ceilings, and two integration expectations. It is specific and matches the changeset. It is long at 106 characters, but it is accurate and scannable.
Full details: Description check
Explanation
The description follows the template's Summary, Changes, and Test plan sections. It explains the purpose and lists each commit with a verification note. The template's Related issue section is not present as a heading, but the summary references #14604 and #14625 and the linked context is clear. The Test plan checklist items from the template are not reproduced, and the Screenshots section is optional. The description is mostly complete and gives concrete verification detail.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
mainreds that are mechanical, stale or a one-line layout pin, as #14604 did:wasi-execution(the runtime does not build for wasm32),lint→ Check formatting, the stale entries of the raw-handle ratchet, and two wasm integration cases left behind by #14625. The GC-safety audits still red onmainare untouched; they need their authors (see #14604).Changes
3d1b0942acrecord_array.rs: thesize_of::<RecordArrayHeader>() == 24assertion (#14487) pinned the 64-bit layout and fails on wasm32 (E0080, thewasi-executionfailure). It now pins fouru32counts then the pointer with no padding (16 + size_of::<*mut u64>()); the capacity (+4) and elems (+16) offset assertions stay. Nothing depends on the width: compiled code reaches the head only through thejs_record_array_*entries, the GC throughelems_slot(addr_of_mut!), andshape_rule3needs only capacity at +4.cargo test --release -p perry-runtime --lib record_array: 16 passed. The full wasip1 runtime build was not run here (needs wasi-sdk's clang); CI'swasi-executionis the check.8b0a3fe3f9cargo fmt --all:crates/perry-runtime/src/lib.rslanded unformatted after #14604.cargo fmt --all -- --checkOK0ab35ab584scripts/raw_handle_debt_files.txt: deletes the eleven per-module ceilingsraw_handle_debt.pyreports as "matches nothing -- DELETE its line" (global_this_webassembly.rsand ten test modules).--no-raise-vs upstream/main: baseline 861 → 861, ceilings 107 → 96, none raised; no "matches nothing" left. (The summary ofrun_lint_gates.shshows only the first of them; the gate itself lists all eleven.)b5b3522be3tests/integration/wasm/{20_string_from_char_code,22_cross_module_nested_object}.expected: #14625 madeconsole.log(a, b)print one line, as Node does, but kept the old one-value-per-line expectations, so both cases fail onmain. New contents are Node's output (the cross-module case run with explicit.tsimports).tests/integration/wasm/run_wasm_tests.shback to 28 pass / 4 fail (10_higher_order,11_map_set_json,14_regex_date,19_ffi_imports).Test plan
BASE_SHA=<merge-base> SKIP_COMPILE_GATES=1 bash scripts/run_lint_gates.shon this branch and on pristinemain, FAIL sets compared: the branch fixes Check formatting and adds no FAIL.cargo clippy -p perry --binsexits 0. (Last full run onb58bade7ac; the commits since, up toedd8d7f5d3, touch none of this PR's files, and fmt / file-size / raw-handle were re-run onedd8d7f5d3.)llvm-objcopy), Array-type predicate lint self-test (BSD grep).Checklist
feat:/fix:/docs:/chore:prefix convention used in the log🤖 Generated with Claude Code
https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
Summary by CodeRabbit
wasm32-wasip1target.