"registration_ids" field is not a JSON array #8

Activity

1. Barryrowe commented on Apr 25, 2014

   

   Barryrowe

   on Apr 25, 2014

   More actions

   I get the same thing. I don't believe the JSON message is being parsed correctly before being sent. Haven't tracked down the exact code location yet.
2. miopa commented on Nov 16, 2014

   

   miopa

   on Nov 16, 2014

   More actions

   Edit: This will only work for less than 1000 devices, the real fix for the issue is here lemonlabs@87484d2

   This version works properly, sends to all devices with one request

   Sender.prototype._sendJSONRequest = function (options, attemptOptions, message, registration_ids, callback) {
       var self = this;
       message['registration_ids'] = registration_ids;
   
       options['headers']['Content-Type'] = 'application/json; charset=utf-8';
       options['headers']['Content-length'] = Buffer.byteLength(JSON.stringify(message), 'utf8');
   
       if (!util.isArray(registration_ids)) return callback(new Error('registration_ids must be an array'));
   
       var multicastResult = new MulticastResult();
   
       options['body'] = JSON.stringify(message);
       debug('HTTP OPTIONS > %s', JSON.stringify(options));
   
       attempt(
           function (attempts) {
               debug('DEBUG > attempts : %s', attempts);
               self._sendRequest(options, this);
           },
           attemptOptions,
           function (err, data) {
               if (err) return callback(err);
   
               try {
                   data = JSON.parse(data);
   
                   multicastResult.addMulticastId(data.multicast_id);
                   multicastResult.setSuccessLength(data.success);
   
                   var results = data.results;
   
                   for (var i = 0; i < results.length; i++) {
                       if (results[i].hasOwnProperty('registration_id')) {
                           multicastResult.addCanonicalIdObject({
                               message_id: results[i].message_id,
                               registration_id: registration_ids[i],
                               new_registration_id: results[i].registration_id
                           });
                       } else if (results[i].hasOwnProperty('error')) {
                           multicastResult.addFailureValueWithKey(results[i].error, registration_ids[i]);
                       }
                   }
                   callback(null, multicastResult.toJSON());
               } catch (ex) {
                   callback(ex);
               }
           }
       );
   };