Skip to content

fix: add .netns_ok flag + regression test for Linux < 5.14 - #92

Open
acbk2b wants to merge 1 commit into
PlatformLab:rhel8from
acbk2b:fix/rhel8-netns
Open

acbk2b wants to merge 1 commit into
PlatformLab:rhel8from
acbk2b:fix/rhel8-netns

Conversation

@acbk2b

@acbk2b acbk2b commented Sep 17, 2026

Copy link
Copy Markdown

What?

Missing network-namespace support declaration

Fix

  • Add .netns_ok = 1 in homa_protocol in homa_plumbing.c
  • Add a regression test to catch deletion of the protocol
    • Gated for Linux < 5.14

Why?

.netns_ok is required for Linux < 5.14, which includes RHEL 8. This fix is not needed in main, as Linux >= 5.14 removed .netns_ok entirely

Testing?

Added a regression test which spot checks the inclusion of .netns_ok, and is gated for Linux < 5.14 only. All 800 tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant