Skip to content

fix(outgoing): keep homa_tx_skb_alloc frag length arithmetic signed #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
randomizedcoder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(outgoing): keep homa_tx_skb_alloc frag length arithmetic signed #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions homa_outgoing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,10 +289,14 @@ struct sk_buff *homa_tx_skb_alloc(struct homa_rpc *rpc, u32 offset, u32 *end)
msg_frags_left > 0) {
skb_frag_t *skb_frag = &shinfo->frags[shinfo->nr_frags];
struct page *page;
int frag_bytes;
int frag_avail, frag_bytes;

frag_bytes = min(skb_frag_size(msg_frag) - bytes_to_skip,
bytes_left);
/* skb_frag_size() is unsigned; keep the min() operands signed
* (matching bytes_left and frag_bytes) so a mixed-sign compare
* can't turn an underflow into a huge positive length.
*/
frag_avail = (int)skb_frag_size(msg_frag) - bytes_to_skip;
frag_bytes = min(frag_avail, bytes_left);
page = skb_frag_page(msg_frag);
get_page(page);
skb_frag->netmem = page_to_netmem(page);
Expand Down