feat(api): add user filters to typed lookups - #980
Merged
Conversation
❌ Deploy Preview for coreprotect failed. Why did it fail? →
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
Addressed CodeFactor’s Complex Method finding by extracting inclusion UUID resolution into a private helper, with no change to filter behavior. Re-ran the existing Paper API probe on fresh SQLite and DuckDB databases: 5716 assertions each, zero failures. CodeFactor now passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
usersandexcludeUserstoLookupOptionsso typed lookups can include multiple users or exclude users before pagination.The existing
user(...)keeps its behavior and remains an additional constraint. Username history resolves these filters by UUID, including historical names.Validated on Paper 26.2 build 121 with SQLite and DuckDB using seeded history, covering all nine typed lookups, user combinations, locations, time, and pagination. Existing material-filter regression checks also pass.