Repository navigation
Add ACS 2020–2024 county income source packages - #386
Merged
Merged
Conversation
…for 2023 source_package_count counts built packages only; the seven ACS county packages have no 2023 artifact and land in skipped_sources (17 -> 24). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ledger-source-fidelity and ledger-boundary judges passed at cc7d6f2 with two findings, both applied here: - Puerto Rico's 78 municipios are now emitted like every other county row (3,222 rows: 3,144 non-PR counties plus 78), matching acs_s0101_state_2024 and acs_s2201_district_2024. Scope selection belongs to consumers. PR's 76 sentinel B01003 MOEs (-555555555 with *****) go to unavailable_cells and never become facts. - B19013's margin of error now carries aggregation "median" like its estimate. All seven source_package.yaml files were regenerated with the generator; --check passes twice and the raw JSON SHA-256 pins are unchanged. Facts: 166,760 -> 170,896. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Judges at 517ee9d: ledger-source-fidelity PASS, ledger-boundary PASS (Subfleet run 20261023-232551-lwi-j2-chr386). Their one should-fix was that the nine mutation tests couldn't create temp directories in the judge sandbox. I reran |
MaxGhenis
marked this pull request as ready for review
October 24, 2026 05:21
MaxGhenis
added a commit
that referenced
this pull request
Oct 24, 2026
…ort sources The one conflict is in tests/test_chronicle_bundle.py's source-package pins. This branch adds built packages, so it keeps source_package_count at 415. #386's seven county packages have no 2023 artifact and are skipped, so main's skipped_source_count of 24 and its skipped-source list are taken. The diff from the reviewed head 49809b6 is exactly #386's diff from 200bf6d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 24, 2026
The package adds 565 government facts at tax_year:2025, one per existing commune key, so geography_count is unchanged and commune:11002 goes from 9 to 10. It adds one source, one source table and one built package. SPF spells nine communes unlike Statbel, and the package keeps SPF's wording, so nine commune geography-name warnings are added (123 -> 132). The deltas were measured with Chronicle's own bundle functions. A replay of the full bundle test against #385's CI bundle, with #386's seven skipped county packages and this package added, passes, and main's unchanged test fails against it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 24, 2026
…ages The two packages add 34,881 person facts at country:BE: 34,629 quarterly daily-wage-class cells from 2023 Q1 to 2026 Q1, and 252 annual key figures for 2020-2025. They add two sources, two source tables and two built packages. They add no new geography, period or entity key and no warning. This stacks on #387's pins. The deltas were measured with Chronicle's own bundle functions and confirmed against #388's CI bundle on the old base. A replay of the full bundle test against #385's CI bundle, with #386's skipped packages, #387's package and these two packages added, passes, and #387's test fails against it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 24, 2026
The package adds 35 calendar-2025 facts: 19 person, 2 benefit_unit premium payments and 14 government expenditure. It adds one statistical_scope geography, the German-speaking Community, plus one source, one source table and one built package. It adds no warning. This stacks on #388's pins. The deltas were measured with Chronicle's own bundle functions and confirmed against #389's CI bundle on the old base. A replay of the full bundle test against #385's CI bundle, with #386's skipped packages and #387's, #388's and this package added, passes, and #388's test fails against it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 24, 2026
anth-volk
added a commit
that referenced
this pull request
Oct 26, 2026
…n-value Brings in main at 272c987: FSA portfolio and ACS S1501 (#347), the certifi lock (#378), NZ QES earnings and PREFU 2026 (#382), UK excise facts (#384), Statbel commune population (#383), Belgian exchange-rate and pension sources (#385), ACS 5-year county income (#386), SPF Finances commune surcharge (#387), RSZ wage classes (#388), Ostbelgien Kindergeld (#389) and GSGB 2025 gambling participation (#391). One file conflicted, tests/test_chronicle_bundle.py, in the merged-bundle warning pins: - warning_count: main's 133 is 91 geography-name warnings, 24 groupby value label warnings, 17 cross-package value label warnings and one duplicate semantic key. This branch turns the value label warnings into errors, so the pin is 92 (91 + 1). Both sides' comments are kept, and the #376 comment now says it removes 41 (17 + 24). - The warning-code Counter keeps main's 91 geography-name warnings and drops the two value label codes, as this branch does. - The list of cross-package value label warnings (main's, now with freq=A) is replaced by this branch's assertion that no value label error or warning remains. Every other count pin is main's: this branch adds no fact. The 92 holds only once freq=A and GSGB's national_lottery_draws_in_person each have one label, which this merge does not choose. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
added a commit
that referenced
this pull request
Oct 26, 2026
After merging main (dece5e9), 3,238 dimension values are emitted by two or more default-bundle packages and worded one way, and the register did not list them. Each takes its one wording, as the register's rule says; no existing entry changes or goes: - census_acs.county: 3,222 county codes from the seven ACS 5-year county packages (#386); - statistic estimate and margin_of_error (ACS county packages, ONS families and households); - NZ QES and PREFU earnings_component, earnings_denominator, earnings_sector, earnings_series_reference and seasonal_adjustment (#382); - UK published_unit (gbp_million, million_sticks, thousand_kilograms) and accounting_basis cash (#384); - age_band age_25_to_34 and age_65_to_74 (GSGB 2025 and HMRC CGT by age); - time 2025 (the two 2025 Eurostat packages). The register now holds 8,062 values in 155 dimensions (4,824 in 147 before). BUILD_YEARS adds the 14 new packages with no 2023 artifact (the eight ACS packages at 2024, the six FSA portfolio packages at 2026), and the register records dece5e9 as the commit its packages were built at. Four values worded more than one way still need a chosen label, so the script cannot yet reproduce this file and --static-check reports two declarations the register contradicts: freq=A, income_range=all, gambling_commission.gsgb_activity=national_lottery_draws_in_person and salary_sacrifice_threshold_position=all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds seven Census ACS 2020–2024 5-year county source packages, with publisher estimates and margins of error kept as separate facts. The 2024 Census API dataset exists, so no 2023 fallback was needed.
Status: implementation and validation complete; retained as a draft for maintainer review. Three commits pin the publisher artifacts, add exact source-column bound validation, and add the generated packages and county tests.
The supplied 2026-10-24 publisher JSON files were copied unchanged, with SHA-256 pins in seven data manifests and FETCH-MANIFEST.json. No county responses were re-fetched. Source URLs contain no API credentials. R2 fields are content-addressed locators; this PR does not assert that bytes were uploaded.
All seven publisher responses contain 3,222 county rows including Puerto Rico. Full source rows preserve those responses; facts exclude state 72. County GEO_ID and Census NAME are preserved. B11001 includes total, family, and nonfamily households. B19001 includes its total and all 16 brackets, with income bounds in fact constraints and package metadata; the first and last brackets have unbounded endpoints.
Publisher special cases:
Verified properties:
The generator reuses the existing full JSON-table parser. The small acceptance-validator change recognizes exact typed lower/upper bounds declared on guarded wide-table columns, matching existing row-bound evidence. It does not change schemas, fact values, identities, or periods. MOE concepts and statistic constraints distinguish them from estimates; metadata explicitly prohibits adding MOEs across categories/counties.
axiom: n/a: source data package
Approved Chronicle agent role: ledger-source-ingestor.
Deterministic checks and tests:
LLM judge verdicts: