Repository navigation
Correct the UK pipeline alignment docs page (#1621) - #1723
Conversation
5d4b027 to
ed2657c
Compare
#1621 is an umbrella tracker. Persist it in-repo as a docs page so the queue of architectural fixes has a stable reference. Auditing the current state: - The three small bugs flagged in the issue body (tax_credits min_benefit unit, benunit_weekly_hours label, state_pension_type heuristic) have all been fixed since the issue was filed. Note them as done. - The state pension residual is documented separately in #1632 (now covered by docs/book/programs/gov/dwp/state-pension.md), so this page links there rather than restating. The remaining architectural gaps captured: - runtime _reported consultation in would_claim_housing_benefit, would_claim_IS, would_claim_WTC, would_claim_CTC — needs conversion to input-only matching the UC/PC pattern, with stochastic assignment in policyengine-uk-data; - take-up assignment in uk-data ignores reported data — needs port of the US assign_takeup_with_reported_anchors helper; - second-stage QRF gap on SPI donors (analogous to policyengine-us-data#589) so consequential FRS-only variables (rent, gift_aid, pension contributions, *_reported benefits) are consistent with imputed income; - residual aggregate gaps against OBR (income_support, esa_contrib, attendance_allowance, tax_free_childcare, state_pension). Ends with a candidate PR sequence so the receiving repos (this one + policyengine-uk-data) have a low-risk-first ordering.
…gelog fragment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Replace the State Pension residual with the 2024-25 figures documented in docs/book/programs/gov/dwp/state-pension.md (£119.0bn against £131.3bn, -£12.2bn) and point to policyengine-uk-data#493. - Say that tax credits stopped paying all ongoing awards on 5 April 2025 (gov.dwp.tax_credits.active), not only new awards. - Drop the unverified Microcosm release date and "certified" claim. - Remove em dashes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ed2657c to
4e4e02d
Compare
Main already carries this page (added by #2386); the merge brings the branch up to date before the page is corrected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- would_claim_council_tax_reduction also reads _reported (five, not four). - The runtime pattern differs by source: data-built simulations set claims_all_entitled_benefits to false and HB/CTR ignore it, and the CTC, WTC, IS and working-age HB eligibility tests also need a reported award, so setting the flag does not reach non-reporters; the fix changes take-up only for CTR and pension-age HB. - policyengine-uk-data#359 (take-up anchors), #347 (gift aid) and #362 (second-stage QRF, narrower outputs) landed in April 2026, before Microcosm; past-tense description of the old build. - In Microcosm, gift_aid is a stage-1 SPI output, not stage 2. - The non-State-Pension residuals are #1621's April 2026 figures on Enhanced FRS 1.50.3, not May 2026 measurements; most (not all) of the State Pension shortfall arises in building the Enhanced FRS. - #1621's third small item is the ~-on-bool DeprecationWarning, with no fix tracked; state_pension_type was a separate fix (#1618). - The IS phase-out landed in #1631. - Replaced the released .added fragment with a .changed fragment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the independent review of the corrections: - On data-built simulations the flag reaches no new claimant of any of the five (HB and CTR ignore it; the others need a reported award), but in tax-credit years it turns on would_claim_CTC, and CTC_child_element is not gated on is_CTC_eligible, so tax_credits income can enter HB and CTR means tests for families that get no CTC. - The conversion's effect is on awards (CTR and pension-age HB), not on take-up flags, and needs that CTC gate first. - Microcosm's second stage is trained on FRS rows and predicts for SPI rows, with the same outputs as uk-data#362; named the three anchored flags; Enhanced FRS 1.50.3 predates #347, #359 and #362; renamed the small-items heading, which now lists an open item. - Fragment no longer says data-built simulations ignore the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Second-round review (household runs on main): in tax-credit years a hand-entered family with children that reports nothing already claims CTC by default, and CTC_child_element is not gated on is_CTC_eligible, so its tax_credits enters the HB and CTR means tests and the tax credit award the 2024 winter payment tests read (utils/winter_heating.py); families that report CTC but have moved to UC are affected in both kinds of simulation. Microcosm's stage 2 lacks two of #362's reported-benefit outputs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… stage 2 Third-round review (household runs on main): legacy closures on main come only after tax credits end, so those families' tax_credits is zero unless a reform keeps tax credits active; the ungated amount is the child element less the taper and counts as income in CTR and HB means tests rather than always cutting them; Microcosm's stage 2 matched #362 at 75167a6 and has since added eight outputs (54b514f). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
UK hub (Claude build session, for Max) Head: Context. This page already reached main, byte for byte, through #2386 (merged 21 October 2026; batch commit d50ee85), and its Review. I had a verifier extract and check every claim, checked each correction myself, and then ran independent adversarial reviews (with household runs on main). Rounds 1 to 3 asked for changes, and round 4 approved this head. Corrected (17) Gap 1 (
Gaps 2 and 3 (take-up anchoring and the second stage) Residual aggregates Other Checked and correct (unchanged)
Follow-up for the hub (model defect, outside this docs PR)
|
Corrects the UK pipeline alignment planning page (
docs/book/assumptions/uk-pipeline-alignment-plan.md), written for #1621.The page itself is already on main: it shipped in #2386 (merged 21 October 2026), and its original
.addedchangelog entry was released in 2.143.0. This branch has merged main, dropped the released fragment and now carries only corrections to main's copy of the page.What this PR corrects (from its changelog fragment):
The claim-by-claim review behind these corrections, with sources, is in the "Ready for hub review" comment on this PR.
The page also records a model defect outside this docs PR:
CTC_child_elementis not gated onis_CTC_eligible, so in tax-credit years an ineligible Child Tax Credit claimant getstax_creditsthat enter its Housing Benefit and Council Tax Reduction means tests. That needs its own issue and fix.changelog.d/1621-pipeline-alignment-page-corrections.changed.md(changed).🤖 Generated with Claude Code