Repository navigation
Count the FL and SD LIHEAP comments in the source-conflict ratchet baseline - #10334
Merged
Merged
Conversation
…seline The guard (#10287) took its KNOWN_UNMARKED baseline at 0f21a63. FL LIHEAP (#9969) and SD LIHEAP (#9974) merged before the guard did, each with comments the ratchet reads as unmarked source conflicts, so test_conflict_sounding_comments_do_not_grow fails on main from ce9377e. These five files were on main when the guard landed, so they belong in the baseline, one comment each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Merge audit: squash-merged at reviewed head f0524ad (merge commit fec98b8). I admin-merged because the only block was the required approving review.
|
This was referenced Oct 21, 2026
4 tasks done
This was referenced Oct 21, 2026
This was referenced Oct 21, 2026
Open
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_conflict_sounding_comments_do_not_grow(the source-conflict guard from #10287) fails onmainfrom ce9377e. This counts the five files it flags in the guard's baseline.Why it fails. The guard took its
KNOWN_UNMARKEDbaseline on its branch at 0f21a63. FL LIHEAP (#9969) and SD LIHEAP (#9974) merged tomainat 21:20Z, before the guard's squash merge at 22:02Z, but after that branch head. So the baseline missed comments of theirs that the ratchet reads as unmarked source conflicts:variables/gov/states/fl/commerce/liheap/eligibility/fl_liheap_eligible.py# Source conflict: manual 900.01A (page 39) allows "non-subsidized rentvariables/gov/states/fl/commerce/liheap/eligibility/fl_liheap_income_limit.py# Source conflict: manual 900.01D (page 39) sets 60% of SMI for sizesvariables/gov/states/fl/commerce/liheap/fl_liheap.py# extrema conflict with it. The FY2025 plan and matrix agree.parameters/gov/states/fl/commerce/liheap/payment/base_amount.yaml# Source conflict: FY2026 plan item 2.6 (page 9) prints an estimated $400parameters/gov/states/sd/dss/liheap/income/limits/table/in_effect.yaml# The published 2024-2025 limits for sizes 4-7 depart from that rule.The fix. These files were on
mainwhen the guard landed, so they belong in its baseline, one comment each, like the other pre-existing files inKNOWN_UNMARKED. The ratchet stays as it was: none of these counts may grow. The comments document where the code's sources disagree, and say which source the code follows. Four of these conflicts are already candidates insource_conflicts/candidates.yaml:us-fl:liheap-energy-in-unsubsidized-rent,us-fl:liheap-large-household-contract-limit,us-fl:liheap-size-13-income-limitandus-sd:liheap-2025-published-income-limit. FL's FY2026 plan payment estimate against the October 2025 matrix (base_amount.yaml,fl_liheap.py) is not a candidate yet. Neither is the manual-against-manual income-limit conflict recorded infl_liheap_income_limit.py. None of them can carry a marker yet: the vendored register has no FL or SD entry, and a marker must name a registered entry. A separate change will:main.Verification. On
mainat 7545b2c and at 1f678c7,policyengine_us/tests/code_health/test_source_conflicts.pygives 1 failed, 102 passed. Main's own CI shows the same failure: push run 39541095730, job "Rest (Python, shard-1 + variables)". With this change it gives 103 passed, both on this branch and merged intomainat 1f678c7. I ran a copy of the file outside the package, so pytest doesn't importpolicyengine_us. It needs only pytest and PyYAML. Every open PR that mergesmainfrom ce9377e or later hits the same failure until this lands.🤖 Generated with Claude Code