Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # policyengine_us/programs.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10432 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 4 10 +6
Lines 76 186 +110
Branches 2 2
==========================================
+ Hits 76 186 +110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PR Review: Add Nevada Energy Assistance Program Fixed Annual CreditPR #10432 (author: hua7450), head
The PR has no reviews and no comments apart from Codecov. It touches no partner test file. Path prefixes:
Sources read for this review:
SummaryWhat is right. The values, the formula and nearly all the rules are encoded correctly:
There are no critical findings and two should-address items:
There are also six suggestions:
Status.
Critical (must fix)None. Should addressS1. 21 of the 28 income-source entries, and the unearned per-source floor, have no test that would fail if they were dropped
S2. The FAC energy cost includes service fees, which the manual excludes, so the benefit is overstated for households below the cap
SuggestionsG1. Record the two source conflicts the PR resolves.
G2. Military pay.
G3.
G4. Document two more income approximations.
G5. A mixed-state case (item 15). No case runs a Nevada and a non-Nevada SPM unit in one simulation.
G6. Earlier years. Every parameter starts on 2025-07-01, so model years before 2026 backfill SFY2026 values. The registry and the body correctly claim only 2026-2027 and call earlier years unverified. The corpus's FY2024 manual (MTL 01/24) shows a 2.63% burden and a $240 minimum. If earlier years matter, add the SFY2024-SFY2025 values. Otherwise, no change is needed (NJ S3 precedent). Verified correctHand-checked expectations (14, all match the head):
Batch checks:
Axiom line assessment
CI status
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
Requesting changes: 0 critical, 2 should (untested income sources; energy cost includes service fees the manual excludes). Full report in the comment above.
Adds Nevada LIHEAP for state fiscal years 2026 and 2027 (July to June). Nevada's Energy Assistance Program, run by the Division of Social Services (DSS), pays one Fixed Annual Credit (FAC) per year toward the household's primary heating and electric costs. The model counts citizens and qualified noncitizens outside the manual's five-year bar in household size (others' income still counts) and tests eligibility income against 150% of the poverty guideline. The FAC is the household's annual energy cost minus the statewide median energy burden times its FAC income (1.81% in SFY2026, 1.48% in SFY2027), at least $360 and at most the capped benefit for its household size, income band and fuel, plus $100 for targeted households. Benefits range from $360 to $3,136.
Fixes #10422
Regulatory authority
Eligibility
defined_for = StateCode.NVnv_liheap_household_sizesumsnv_liheap_immigration_eligible. A qualified noncitizen (is_citizen_or_legal_immigrant) who entered after August 22, 1996 is barred for five years after entry (years_since_us_entry) unless the person is under 18 (302 C I); a refugee, asylee, Cuban or Haitian entrant, or noncitizen whose deportation is withheld (VI); a veteran or active-duty member, or that person's spouse or unmarried dependent child (VII,is_snap_alien_military_connected); or a lawful permanent resident with 40 qualifying quarters (VIII,snap_alien_qualifying_quarters). Barred and other excluded members' income counts in full (502 A.I); size 0 is ineligiblehas_heating_expense) or heat in the rent;NONEineligible,UNSPECIFIEDonly with heat in rentNo categorical eligibility and no asset test (plans 1.4, 2.2).
Income
Nevada uses two income measures (Manual 702, 705-706).
is_in_k12_school)medicare_part_b_premium; SSI and Nevada's SSA-paid state supplement (nv_oss)financial_assistance), general assistance, strike benefits, trust income, gambling winnings, capital gainstanf)Benefit
is_usda_disabled(SSI, Social Security disability, the veterans' categories) oris_disabled, which stands in for disability retirement, railroad, interim assistance and employer disability benefits: those count only for a disability that is permanent under Social Security standards, whichdisability_benefits,railroad_benefitsandworkers_compensationcannot show.Not modeled
years_since_us_entryplaces them past the barimmigration_statusvalue; not identifiedEarlier years are unverified estimates through parameter backfilling. Model period 2026 is SFY2026 and 2027 is SFY2027.
Microsimulation:
heating_typeand the per-fuel bills are not in current datasets; callers must supply them.Test plan
56 YAML cases in 7 files. The cases were not re-run locally after the 2026-10-22 review fixes; CI runs them.
limits for sizes 1 and 9 in both years, an undocumented member and an all-undocumented household;
the five-year bar: each immigration status two years after entry, the five-year edge, the age-18 edge, 40 quarters for a permanent resident but not a parolee, a veteran, a barred single resident ($0), a barred parent with a citizen child (size 1, over the limit) and an exempt refugee ($1,280);
eligibility income: a 17-year-old student's wages excluded and a non-student's counted, an 18-year-old, Social Security net of Part B, SSI, TANF excluded, capital gains, gambling, child support, retirement withdrawals, a self-employment loss, an undocumented member's income; FAC income adding the student's wages and TANF;
energy cost for gas, electric and solar heat; eligibility at the exact limit, fuel and heat-in-rent cases, subsidized and public housing with and without an energy burden;
the FAC between the minimum and the cap, the $360 minimum, the propane, fuel oil and kerosene caps, the 75% and 125% band edges, zero income, FAC income above 150%, size 9, each targeted group and its age edges, a blind SSI recipient without the disability flag (countable income of $13,239.60 with
nv_oss), the $3,136 maximum, and SFY2027 at 1.48%.YAML tests with expected values from the statute, manuals and plans
ruff formatChangelog fragment in
changelog.d/CI passes
axiom: TheAxiomFoundation/rulespec-us#1893 queued
🤖 Generated with Claude Code